Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when loading from non-ASCII path with pop-up file browser #3

Open
RubberDuckShobe opened this issue Mar 22, 2024 · 0 comments
Open

Crash when loading from non-ASCII path with pop-up file browser #3

RubberDuckShobe opened this issue Mar 22, 2024 · 0 comments
Labels
base game bug For anything involving fixing bugs of the base game. good first issue Good for newcomers help wanted Extra attention is needed

Comments

@RubberDuckShobe
Copy link
Contributor

RubberDuckShobe commented Mar 22, 2024 •
edited
Loading

During song selection, clicking the button to open a pop-up file browser (windows file open dialog) and then choosing a song with a path that contains non-ASCII charaters causes the game to crash with a C++ runtime error.

The BASS_PreCalc hook shows that in the path, the offending characters just get replaced with a literal ?, which breaks the game.

The channel type handling the dialog is Aco_FileDialogChannel.

image

This bug happens without the Wavebreaker client too - it's a base game bug!
@RubberDuckShobe RubberDuckShobe added good first issue Good for newcomers help wanted Extra attention is needed base game bug For anything involving fixing bugs of the base game. labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
base game bug For anything involving fixing bugs of the base game. good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RubberDuckShobe