[C-1107] Fix push to sign in when identity is down (#1931)

AudiusProject · Sep 15, 2022 · 54dcd64 · 54dcd64
1 parent 43222ee
commit 54dcd64
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/packages/common/src/services/audius-backend/AudiusBackend.ts b/packages/common/src/services/audius-backend/AudiusBackend.ts
@@ -2240,7 +2240,7 @@ export const audiusBackend = ({
       return emailExists
     } catch (error) {
       console.error(getErrorMessage(error))
-      return true
+      throw error
     }
   }
 

diff --git a/packages/mobile/src/screens/signon/SignOn.tsx b/packages/mobile/src/screens/signon/SignOn.tsx
@@ -641,12 +641,19 @@ const SignOn = ({ navigation }: SignOnProps) => {
                   signOnActions.checkEmail(
                     email,
                     () => {
+                      // On available email, move to create password
                       navigation.replace('CreatePassword')
                       setIsWorking(false)
                     },
                     () => {
+                      // On unavailable email (e.g. user exists with that email),
+                      // Switch to the sign in form
                       switchForm()
                       setIsWorking(false)
+                    },
+                    () => {
+                      // On any unknown error, do nothing, but let the user try again
+                      setIsWorking(false)
                     }
                   )
                 )

diff --git a/packages/web/src/common/store/pages/signon/actions.ts b/packages/web/src/common/store/pages/signon/actions.ts
@@ -97,9 +97,10 @@ export function resetSignOn() {
 export function checkEmail(
   email: string,
   onAvailable?: () => void,
-  onUnavailable?: () => void
+  onUnavailable?: () => void,
+  onError?: () => void
 ) {
-  return { type: CHECK_EMAIL, email, onAvailable, onUnavailable }
+  return { type: CHECK_EMAIL, email, onAvailable, onUnavailable, onError }
 }
 
 /**

diff --git a/packages/web/src/common/store/pages/signon/sagas.js b/packages/web/src/common/store/pages/signon/sagas.js
@@ -289,6 +289,7 @@ function* checkEmail(action) {
     }
   } catch (err) {
     yield put(signOnActions.validateEmailFailed(err.message))
+    yield call(action.onError)
   }
 }