Fix infinite 404 (#1920)

AudiusProject · Sep 13, 2022 · 7a95b3f · 7a95b3f
1 parent 8cdc9b9
commit 7a95b3f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 12 deletions.
diff --git a/packages/common/src/services/audius-api-client/AudiusAPIClient.ts b/packages/common/src/services/audius-api-client/AudiusAPIClient.ts
@@ -426,7 +426,7 @@ type GetUserSupporterArgs = {
 
 type AudiusAPIClientConfig = {
   audiusBackendInstance: AudiusBackend
-  audiusLibs?: AudiusLibs
+  getAudiusLibs: () => AudiusLibs
   overrideEndpoint?: string
   remoteConfigInstance: RemoteConfigInstance
   localStorage: LocalStorage
@@ -439,22 +439,22 @@ export class AudiusAPIClient {
   }
 
   audiusBackendInstance: AudiusBackend
-  audiusLibs?: AudiusLibs
+  getAudiusLibs: () => AudiusLibs
   overrideEndpoint?: string
   remoteConfigInstance: RemoteConfigInstance
   localStorage: LocalStorage
   env: Env
 
   constructor({
     audiusBackendInstance,
-    audiusLibs,
+    getAudiusLibs,
     overrideEndpoint,
     remoteConfigInstance,
     localStorage,
     env
   }: AudiusAPIClientConfig) {
     this.audiusBackendInstance = audiusBackendInstance
-    this.audiusLibs = audiusLibs
+    this.getAudiusLibs = getAudiusLibs
     this.overrideEndpoint = overrideEndpoint
     this.remoteConfigInstance = remoteConfigInstance
     this.localStorage = localStorage
@@ -1513,11 +1513,10 @@ export class AudiusAPIClient {
     }, {})
 
     const formattedPath = this._formatPath(pathType, path)
-    const audiusLibs =
-      this.audiusLibs ??
-      (this.initializationState.type === 'libs' && window.audiusLibs)
-    if (audiusLibs) {
-      const data = await audiusLibs.discoveryProvider._makeRequest(
+    const audiusLibs = this.getAudiusLibs()
+
+    if (audiusLibs && this.initializationState.type === 'libs') {
+      const data = await audiusLibs.discoveryProvider?._makeRequest(
         {
           endpoint: formattedPath,
           queryParams: sanitizedParams,

diff --git a/packages/mobile/src/services/audius-api-client/apiClient.ts b/packages/mobile/src/services/audius-api-client/apiClient.ts
@@ -8,8 +8,7 @@ import { remoteConfigInstance } from '../remote-config'
 export const apiClient = new AudiusAPIClient({
   audiusBackendInstance,
   remoteConfigInstance,
-  // @ts-ignore
-  audiusLibs,
+  getAudiusLibs: () => audiusLibs,
   localStorage,
   env
 })
diff --git a/packages/web/src/services/audius-api-client/apiClient.ts b/packages/web/src/services/audius-api-client/apiClient.ts
@@ -8,7 +8,7 @@ import { remoteConfigInstance } from 'services/remote-config/remote-config-insta
 export const apiClient = new AudiusAPIClient({
   audiusBackendInstance,
   remoteConfigInstance,
-  audiusLibs: window.audiusLibs,
+  getAudiusLibs: () => window.audiusLibs,
   localStorage,
   env
 })