This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
[PAY-598] Prepopulate TransactionDetails after purchasing $AUDIO #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wire up transaction details at the end of the purchase saga - Update fee calculation to use fancy helper method on Transaction - Add default fee if fee calculation fails of 5000 Lamports - Replace u64 with BN
|
Preview this change https://demo.audius.co/mjp-transaction-details-modal-wired |
|
Preview this change https://demo.audius.co/mjp-transaction-details-modal-wired |
piazzatron
approved these changes
Sep 1, 2022
| balance: StringAudio | ||
| metadata: InAppAudioPurchaseMetadata | undefined | ||
| } | ||
| export type TransactionDetails = |
| return libs().solanaWeb3Manager.solanaWeb3.Keypair.fromSeed( | ||
| libs().Account.hedgehog.wallet.getPrivateKey() | ||
| ) as Keypair | ||
| return libs().solanaWeb3Manager!.solanaWeb3.Keypair.fromSeed( |
There was a problem hiding this comment.
all the services are nullable :(
| data: InAppAudioPurchaseMetadata | ||
| ) => { | ||
| await waitForLibsInit() | ||
| // return await libs().identityService!.saveUserBankTransactionMetadata(data) |
There was a problem hiding this comment.
ah just saw the commit msg
|
Preview this change https://demo.audius.co/mjp-transaction-details-modal-wired |
audius-infra
pushed a commit
that referenced
this pull request
Sep 3, 2022
[6eeb9d4] [PAY-605][PAY-601][PAY-548] Buy Audio modal design changes (#1846) Marcus Pasell [436cd27] [C-963] Migrate wallet sagas (#1857) Sebastian Klingler [238d729] [C-959] Migrate tipping sagas (#1852) Sebastian Klingler [1561728] Bump SDK to v1.0.1 (#1842) Dheeraj Manjunath [a331f3d] Add reordering to new tables for playlists (#1845) Kyle Shanks [3c90d3f] [PAY-598] Prepopulate TransactionDetails after purchasing $AUDIO (#1832) Marcus Pasell [b11a686] [C-957] Fix autocomplete when signed out (#1844) Sebastian Klingler [3315c27] Make tooltips use updated colors when theme is applied (#1843) Sebastian Klingler [76395d5] [PAY-591] Improve supporter count visibility (#1841) Reed [779d9e9] [PAY-507] Fix feed tip tile tip button resizing (#1837) Reed [f4160e9] [C-939] Refactor discord modal (#1838) Dylan Jeffers [b76854f] Update deactivate copy (#1840) Raymond Jacobson [2085ffc] [Stems] Don't rewrite to /index.html on stems.audius.co (#1836) Marcus Pasell [14aa5ac] [C-836] Fix enter on search (#1835) Dylan Jeffers [d644cc1] [C-703] Fix segmented control font color (#1833) Dylan Jeffers [d2c0dca] [C-934] Migrate user-list sagas to common (#1829) Dylan Jeffers [1321a57] [C-919] Migrate profile sagas to common (#1826) Sebastian Klingler [aad5c6a] [PAY-594] Edit 'not enough SOL' error message (#1827) Reed [af61aab] [C-930] Move social sagas to common (#1822) Raymond Jacobson [33a1403] [C-928] Migrate saved sagas to common (#1821) Dylan Jeffers [64d45f3] [PAY-544] Add Transaction Details Modal (#1806) Marcus Pasell [20cfc9f] Add Transaction Details to Store (#1804) Marcus Pasell [5b8a4f0] [C-926] Migrate explore sagas to common (#1818) Dylan Jeffers [6047185] Follow up fix for track removal from playlist with entity manager (#1817) Isaac Solo [1b2638c] Fix track removal from playlist with entity manager (#1815) Isaac Solo [c854f66] [C-918] Move trending saga to common (#1814) Dylan Jeffers [6f24724] Fix lineup types in mobile build (#1812) Dylan Jeffers [27cf13a] Update @audius/sdk to 1.0.0 (#1813) Reed [c10ef33] Only enable external sourcemaps for prod builds (#1811) Sebastian Klingler [67e9c2d] [PAY-479] Check recipient wallet SOL before send (#1779) Reed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Populate the TransactionDetails for the just-completed transaction at the end of the BuyAudio modal so that "Review Transaction" can work without a query to Discovery/Identity
u64toBNwhere possibleDragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
created_atinstead. (blocktimedoesn't seem to be available right away so this avoids the 'undefined' case - also since this doesn't have to be tied to one particular userbank tx this seems ok)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Tested E2E using phantom to mock Coinbase Pay
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.
Only entry point is currently behind the BUY_AUDIO_ENABLED feature flag