This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
Fix iOS safari video thumbnail and limit video support #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondjacobson
approved these changes
Apr 12, 2021
| ] | ||
| const OPENSEA_AUDIO_EXTENSIONS = ['mp3', 'wav', 'oga'] | ||
|
|
||
| const SUPPORTED_VIDEO_EXTENSIONS = ['webm', 'mp4', 'ogv', 'ogg', 'mov'] |
There was a problem hiding this comment.
Just read a bit more into this
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video
it sounds like not all browsers support the same things and you can use multiple
sliptype
pushed a commit
that referenced
this pull request
Feb 11, 2022
* Limit collectible video formats supported * Fix iOS video inline autoplay * Add comments Co-authored-by: Saliou Diallo <saliou@audius.co>
sliptype
pushed a commit
that referenced
this pull request
Feb 12, 2022
* Limit collectible video formats supported * Fix iOS video inline autoplay * Add comments Co-authored-by: Saliou Diallo <saliou@audius.co>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix iOS safari video thumbnail and limit video support
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Tested locally