token conversion #61
Merged
token conversion #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phraktle
requested changes
Mar 30, 2018
contracts/MonetarySupervisor.sol
Outdated
| 5) MonetarySupervisor issues new tokens to user's account in current AugmintToken | ||
| 6) MonetarySupervisor burns old tokens from own balance | ||
| */ | ||
| function transferNotification(address from, uint amounToConvert, uint) public { |
There was a problem hiding this comment.
misspelled amountToConvert.
also, as a convention, I would always use the parameter names from the original interface (amount and data in this case), since that defines the purpose of these already (and the unnamed param looks particularly strange to me :)
There was a problem hiding this comment.
amount param name changed. data param is not used, we get compile warnings if I name the param, added a comment
Pull Request Test Coverage Report for Build 400
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.