Add rebuildVolumeForAllMarkets() and migration to run it #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebuildVolumeForAllMarkets() was added to facilitate a recent volume fix which required a full DB reset. It can also be used in future unit testing to verify that incremental and non-incremental methods of volume calculation produce the correct result. Or as an ongoing sanity check: executing rebuildVolumeForAllMarkets() on a production database should result in no changes. Related to AugurProject/augur#289
|
Code Climate has analyzed commit b3c621d and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| return new Error(`marketId not found ${tradesRow.marketId}`); | ||
| } | ||
|
|
||
| const volumeFromThisTrade = volumeForTrade({ |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| // a client would just use rebuildVolumeForAllMarkets() which wraps this. But | ||
| // you may want to use this eg. for unit testing, to show that `incremental | ||
| // volume calculation for N trades` == `non-incremental volume calculation`. | ||
| function calculateVolumeForAllMarkets(allMarkets: Array<RebuildVolumeMarketsRow>, allTrades: Array<RebuildVolumeTradesRow>): RebuildVolumeResult | Error { |
There was a problem hiding this comment.
Function calculateVolumeForAllMarkets has 39 lines of code (exceeds 25 allowed). Consider refactoring.
| // a client would just use rebuildVolumeForAllMarkets() which wraps this. But | ||
| // you may want to use this eg. for unit testing, to show that `incremental | ||
| // volume calculation for N trades` == `non-incremental volume calculation`. | ||
| function calculateVolumeForAllMarkets(allMarkets: Array<RebuildVolumeMarketsRow>, allTrades: Array<RebuildVolumeTradesRow>): RebuildVolumeResult | Error { |
There was a problem hiding this comment.
Function calculateVolumeForAllMarkets has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
nuevoalex
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebuildVolumeForAllMarkets() was added to facilitate a recent volume fix which
required a full DB reset.
It can also be used in future unit testing to verify that incremental and
non-incremental methods of volume calculation produce the correct result.
Or as an ongoing sanity check: executing rebuildVolumeForAllMarkets() on a
production database should result in no changes.
Related to AugurProject/augur#289