wallet fixes #10720
Merged
wallet fixes #10720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnDanz
requested review from
phoebemirman
and removed request for
bconfortin
phoebemirman
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues with Coinbase wallet #10612
testnet isn't supported with WalletLink at this time. coinbase/coinbase-wallet-sdk#41 (comment)
Portis is not working, even via HTTPS #10614
Portis is just broken with safari currently when used by the connect libraries we are using.
This should fix itself when wallet-connect npm package updates to use latest SDK version --- until then i've hide Portis in safari.