Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework RSA #20

Merged
merged 8 commits into from
Apr 5, 2024
Merged

Rework RSA #20

merged 8 commits into from
Apr 5, 2024

Conversation

KubEF
Copy link
Contributor

@KubEF KubEF commented Apr 4, 2024

Rework RSA at more natural and strict way. Add dot representation, rename confusing functions and fields.

KubEF and others added 5 commits March 19, 2024 21:05
@KubEF
Rework recursive_automaton
e64609a 
Rename labels to nonterminals, delete _labels set,
because it can be expressed by _box dict. Also some
minor rework Box class and add to_dot function.
@KubEF
Rewrite tests to actual implementation
af8f93a
@KubEF
Merge branch 'Aunsiels:master' into rsa_rework
186d71b
@KubEF
Remove all 'changing' functions and empty constructors
8cb66d6
@KubEF
Merge pull request #1 from KubEF/rsa_rework
d183403 
Rsa rework
Aunsiels
Aunsiels requested changes Apr 4, 2024
View reviewed changes
Copy link
Owner

@Aunsiels Aunsiels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I added some comments to improve the code.

pyformlang/rsa/box.py Show resolved Hide resolved
pyformlang/rsa/recursive_automaton.py Outdated Show resolved Hide resolved
pyformlang/rsa/recursive_automaton.py Outdated Show resolved Hide resolved
pyformlang/rsa/recursive_automaton.py Outdated Show resolved Hide resolved
pyformlang/rsa/recursive_automaton.py Outdated Show resolved Hide resolved
pyformlang/rsa/recursive_automaton.py Outdated Show resolved Hide resolved
pyformlang/rsa/box.py Outdated Show resolved Hide resolved
pyformlang/rsa/recursive_automaton.py Outdated Show resolved Hide resolved
pyformlang/rsa/recursive_automaton.py Outdated Show resolved Hide resolved
pyformlang/rsa/tests/test_rsa.py Outdated Show resolved Hide resolved
@KubEF KubEF requested a review from Aunsiels April 4, 2024 13:37
Aunsiels
Aunsiels requested changes Apr 4, 2024
View reviewed changes
Copy link
Owner

@Aunsiels Aunsiels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests do not pass for Python <=3.9 because of some new features of 3.10. Could you please fix it?

pyformlang/rsa/box.py Outdated Show resolved Hide resolved
pyformlang/rsa/box.py Show resolved Hide resolved
@KubEF
Fix signatures and to_dot
0768274 
Change 'Symbol | str' to Union[Symbol, str] and
add reducing special symbols in to_dot
@KubEF KubEF requested a review from Aunsiels April 5, 2024 09:54
Aunsiels
Aunsiels approved these changes Apr 5, 2024
View reviewed changes
Copy link
Owner

@Aunsiels Aunsiels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks :)

@Aunsiels Aunsiels merged commit 192586b into Aunsiels:master Apr 5, 2024
3 of 4 checks passed
@KubEF
Copy link
Contributor Author

KubEF commented Apr 5, 2024

Thank you for your comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aunsiels Aunsiels Aunsiels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KubEF @Aunsiels