Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clipped text of terminal color attributes #480

Closed
Angelk90 opened this issue Sep 16, 2023 · 1 comment · Fixed by #538
Closed

Clipped text of terminal color attributes #480

Angelk90 opened this issue Sep 16, 2023 · 1 comment · Fixed by #538
Assignees
@mishapark
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest #Hacktoberfest Theme Aurora Editor Theme UI Related to User Interface Verified Verified bug
Milestone
Version 1.0

Comments

@Angelk90
Copy link
Contributor

Angelk90 commented Sep 16, 2023 •
edited

Description

As you can see from the images the texts are cut.

Screenshot 2023-09-16 alle 12 05 10

To Reproduce

Tested on Themes -> Terminal

Version information

Aurora Editor: 1.0 (20230915.2006)
Commit: 38620af
MacOS: 13.5.2 (22G91)
Xcode: 14.3.1 (14E300c)
@Angelk90 Angelk90 added bug Something isn't working unverified bug report what is not yet verified. labels Sep 16, 2023
@0xWDG 0xWDG added good first issue Good for newcomers UI Related to User Interface Verified Verified bug hacktoberfest #Hacktoberfest Theme Aurora Editor Theme and removed unverified bug report what is not yet verified. labels Sep 16, 2023
@0xWDG 0xWDG added this to the Version 1.0 milestone Sep 23, 2023
@mishapark
Copy link
Contributor

Hi, please assign this issue to me

@mishapark mishapark mentioned this issue Oct 1, 2023
Merged
6 tasks
@0xWDG 0xWDG closed this as completed in #538 Oct 1, 2023
0xWDG added a commit that referenced this issue Oct 1, 2023
@0xWDG
Fixed clipped color text and added scrollview (#538)
e27533c 
## Summary

- Closes #480 
- Fixes clipped text for color attributes
- Adds ScrollView to fit all the attributes

## Changes Made

- Moved all color attributes into one VStack instead of having two
VStacks
- Added ScrollView

## Motivation

- Closes #480 

## Testing

- Everything works as before, since it is a simple layout fix

## Screenshots/GIFs


![image](https://github.com/AuroraEditor/AuroraEditor/assets/66741910/77797936-a813-455b-b60b-94d18828fbbe)

## Checklist

Please ensure all of the following are completed before submitting the
PR:

- [X] Code has been tested and verified.
- [ ] Documentation has been updated to reflect the changes.
- [X] All tests pass successfully.
- [X] Code follows the project's coding guidelines and style.
- [X] The branch is up-to-date with the latest changes from the main
branch.
- [ ] Reviewed by at least one other contributor.

## Related Issues

This PR addresses the following issue(s): #480 

## Additional Notes

To have a consistent look the sections in the terminal tab may be put in
GroupBox like in the Editor tab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mishapark mishapark

Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest #Hacktoberfest Theme Aurora Editor Theme UI Related to User Interface Verified Verified bug
Projects
AuroraEditor Roadmap
Archived in project
Milestone
Version 1.0
Development

Successfully merging a pull request may close this issue.

Fixed clipped color text and added scrollview mishapark/AuroraEditor
3 participants
@0xWDG @Angelk90 @mishapark