Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build actions to use heaps 1.10.0 explicitly #42

Merged

Conversation

MondayHopscotch
Copy link
Contributor

Using the git version of heaps exposes the build actions of this repo to potential instability as things change. This explicitly uses the 1.10.0 release to provide some stability in the deps required.

@MondayHopscotch
Copy link
Contributor Author

This workflow isn't going to work, as there is a chicken-and-egg problem here. The workflow uses the master version of the composite file, but the updated composite file has to be merged into master before it can be used.

@AustinEast
Copy link
Owner

Hey! Very much appreciate the investigation/PR here. Been on a bit of an online sabbatical but happy to approve now :)

@AustinEast AustinEast merged commit 3ca8cc9 into AustinEast:master Jan 10, 2024
1 check failed
@MondayHopscotch
Copy link
Contributor Author

Welcome back! I'm digging into the shape collision stuff that was reverted to see if I can figure out what's going on. However, setting things up locally, I'm seeing the same C:\HaxeToolkit\haxe\lib\heaps/2,0,0/h3d/impl/ShaderCache.hx:14: characters 33-34 : Unexpected ? build errors coming out of heaps 2.0.0 that was occurring with the master checkout of the heaps library. This PR originally went with 1.10.0 as that was a version that didn't appear to have that issue. Have you tested the build with 2.0.0 and seen it not have that build issue? Not sure if it's somehow related to other deps I have in my local environment, but for now I'm explicitly using 1.10.0 while working on this locally, but figured I'd ask since I saw a commit to use 2.0.0 for the build action.

@AustinEast
Copy link
Owner

That may be an issue from a local dependency 🤔 I did test with/without #41 on both 1.10.0 and 2.0.0, and the issue appeared on both versions of heaps for me!

@MondayHopscotch
Copy link
Contributor Author

Strange, for me, if I have heaps 2.0.0, when I run haxe test.hxml, I throw that error. It's the same error I was seeing when I put the original PR when the github action would run.

@AustinEast
Copy link
Owner

Interesting! Which version of haxe are you on btw?

@MondayHopscotch
Copy link
Contributor Author

I'm running 4.2.5 locally, and it looks like the build action for the repo was using 4.2.4 according to the logs here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants