Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS type definitions and build command #96

Merged
merged 3 commits into from
Aug 8, 2020

Conversation

volkipp
Copy link
Contributor

@volkipp volkipp commented Aug 7, 2020

This should fix those straggling Typescript types which were generating errors on the build command. This also fixes an eslint error which failed if there were no files with ts or tsx extensions in the project.

@volkipp volkipp mentioned this pull request Aug 7, 2020
9 tasks
@AustinGil
Copy link
Owner

Thanks @volkipp. I added these fixes on my local branch already based on your previous comments. But I haven't pushed up yet. I think we have some minor differences, but I'll go ahead and merge this and reconcile those.

Any reason you added the --no-error-on-unmatched-pattern flag for eslint?

@volkipp
Copy link
Contributor Author

volkipp commented Aug 8, 2020

Oh sure I didn’t know if you had gotten around to it or not so I just went for it. I added —no-error-on-unmatched-pattern because eslint didn’t like that there were no tsx files or (at the time) ts files. It took awhile to track down that eslint expects every pattern to be matched and if it’s not it throws an error by default, which seems pretty ridged to me.

@AustinGil
Copy link
Owner

Yeah all good. It's pretty much the same thing anyway and I appreciate you putting in the work on it :)

@AustinGil AustinGil merged commit cfaa2cb into AustinGil:master Aug 8, 2020
@volkipp volkipp deleted the lint-fix branch August 10, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants