Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in ice_plot() regarding _get_quantiles() #18

Closed
savvastj opened this issue May 30, 2017 · 6 comments
Closed

Typo in ice_plot() regarding _get_quantiles() #18

savvastj opened this issue May 30, 2017 · 6 comments

Comments

@savvastj
Copy link

There is a typo in the ice_plot() function when calling the _get_quantiles() function. In lines 124 and 137, the ice_plot() calls __get_quantiles() (which is undefined) instead of _get_quantiles(), which results in an error if trying to use quantiles or center the ICE curves.

@sri-latha
Copy link

Came on here to report the same issue with __get_quantiles() with an extra underscore. Is d-ICE supported in this package? Is that in the pipeline?

@spoonertaylor
Copy link

Hello, I just installed pycebox and am facing this issue. Has this been resolved or is there any idea why I would still be facing this issue? Thanks.

@AustinRochford
Copy link
Owner

How did you install PyCEbox? Since this isn't actively maintained, I don't believe I released the version with the change to PyPI. Perhaps you could try installing from Gitub and see if you get the fix?

@dmbaker
Copy link

dmbaker commented May 19, 2019

One way to fix this is to monkey patch the pycebox.ice module as the original code calls this function instead of the coded _get_quantiles...

import pycebox.ice as icebox
def __get_quantiles(x):
    return np.greater.outer(x, x).sum(axis=1) / x.size
icebox.__get_quantiles = __get_quantiles

@csdalvi
Copy link

csdalvi commented Jul 16, 2019

How did you install PyCEbox? Since this isn't actively maintained, I don't believe I released the version with the change to PyPI. Perhaps you could try installing from Gitub and see if you get the fix?

I tried installing from github but it still shows the same issue

@farshidafshar
Copy link

One way to fix this is to monkey patch the pycebox.ice module as the original code calls this function instead of the coded _get_quantiles...

import pycebox.ice as icebox
def __get_quantiles(x):
    return np.greater.outer(x, x).sum(axis=1) / x.size
icebox.__get_quantiles = __get_quantiles

this worked for me , thank you "dmbaker"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants