Font sizes updated #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadoh
suggested changes
Jul 3, 2019
There was a problem hiding this comment.
I would rather we stick with aragonUI standard components as much as possible, even if it results in a slight divergence from our original design. Benefits:
- when aragonUI gets updated, our interface is automatically updated to match
- a more standard look/feel across aragon apps
@stellarmagnet what do you think? Most of the changes here cause our Profile UI to diverge from aragonUI standards.
chadoh
reviewed
Jul 10, 2019
Before
After
|
chadoh
approved these changes
Jul 10, 2019
There was a problem hiding this comment.
Nice cleanup! I'd like to see two last small changes before merge, but I don't need to re-review once they're implemented, so I'm going ahead and marking "approved" now.
- Rename the new
SchoolCompanyNamecomponent, as suggested in my comment below - Squash the commits together. I don't think having commits in our history with messages like "experiments" will help us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses all small updated mentioned in the associated ticket.