Merge pull request #1275 from AutarkLabs/mainnet-audit-allocations-4-…

…increasedcoverage Updated test to improve coverage
AutarkLabs · Oct 3, 2019 · b850a07 · b850a07
2 parents f85f075 + 70f9819
commit b850a07
Show file tree

Hide file tree

Showing 10 changed files with 197 additions and 100 deletions.
diff --git a/apps/allocations/.solcover.js b/apps/allocations/.solcover.js
@@ -1,6 +1,6 @@
 module.exports = {
   norpc: true,
-  skipFiles: ['misc/Migrations.sol', 'test/TestImports.sol'],
+  skipFiles: ['test/Imports.sol'],
   // TODO: Change this hack when the feel to update solidity-coverage upstream
   // rsync is needed so symlinks are resolved on copy of lerna packages
   testCommand:

diff --git a/apps/allocations/contracts/Allocations.sol b/apps/allocations/contracts/Allocations.sol
@@ -604,4 +604,4 @@ contract Allocations is AragonApp {
     // Must be view for mocking purposes
 
     function getMaxPeriodTransitions() internal view returns (uint64) { return MAX_UINT64; }
-}
+}
diff --git a/apps/allocations/contracts/misc/Migrations.sol b/apps/allocations/contracts/misc/Migrations.sol
diff --git a/apps/allocations/contracts/test/Imports.sol b/apps/allocations/contracts/test/Imports.sol
@@ -0,0 +1,9 @@
+pragma solidity ^0.4.24;
+// HACK to workaround truffle artifact loading on dependencies
+
+import "@aragon/apps-shared-minime/contracts/MiniMeToken.sol";
+import "@aragon/os/contracts/factory/DAOFactory.sol";
+
+
+ // solium-disable-next-line no-empty-blocks
+contract Imports {}
diff --git a/apps/allocations/contracts/test/TestImports.sol b/apps/allocations/contracts/test/TestImports.sol
diff --git a/apps/allocations/migrations/.gitkeep b/apps/allocations/migrations/.gitkeep
diff --git a/apps/allocations/migrations/1_initial_migration.js b/apps/allocations/migrations/1_initial_migration.js
diff --git a/apps/allocations/migrations/2_deploy_contracts.js b/apps/allocations/migrations/2_deploy_contracts.js