Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Every import from "@tps/test-helpers/contracts" should be replaced to "@aragon/os/contracts" #588

Open
3 tasks done
ottodevs opened this issue Mar 15, 2019 · 2 comments · May be fixed by #952
Open
3 tasks done

Every import from "@tps/test-helpers/contracts" should be replaced to "@aragon/os/contracts" #588

ottodevs opened this issue Mar 15, 2019 · 2 comments · May be fixed by #952
Assignees
@ottodevs
Labels
housekeeping General clean-up tasks and things related to making our repo super pretty and easy to use.

Comments

@ottodevs
Copy link
Member

ottodevs commented Mar 15, 2019 •
edited

Background: We used for some time a forked set of @aragon/os contracts at @test-helpers package but not anymore, it seems a good moment to replace those imports to prevent future hard to debug bugs.

We should replace any pending import across every app from:

  • Contracts
  • Test files
  • Any extra contract like Spoof.sol or Imports.sol generally found at test/ or contracts/ folders and subfolders

The final step should be removing the deprecated contracts files from test-helpers package

IMPORTANT: There are still some contracts being used from test-helpers folder, the StandardsBounties related ones, this should be handled carefully to avoid replacing those imports since @aragon/os does not contain bounties related contracts
@ottodevs ottodevs added the housekeeping General clean-up tasks and things related to making our repo super pretty and easy to use. label Mar 15, 2019
@stellarmagnet stellarmagnet added this to the Sprint 19.13 milestone May 26, 2019
@ottodevs
Copy link
Member Author

I started working on this but I found some new issues related to some @aragon/os contract difference with our previous customs @tps/test-helpers imports , coming back to this asap

@Quazia Quazia removed this from the Sprint 19.13 milestone Jun 3, 2019
@ottodevs ottodevs linked a pull request Jun 3, 2019 that will close this issue
Open
@Quazia Quazia added this to the Sprint 19.15 milestone Jun 10, 2019
@ottodevs ottodevs mentioned this issue Jul 11, 2019
Closed
3 tasks
@ottodevs ottodevs mentioned this issue Aug 5, 2019
Closed
7 tasks
@ottodevs ottodevs mentioned this issue Oct 4, 2019
Closed
@stellarmagnet stellarmagnet modified the milestones: Sprint 19.15, Sprint B2 Dec 2, 2019
@stellarmagnet
Copy link
Collaborator

@ottodevs this is the last sprint that we will try to resolve this issue, if it's not completed or you don't think there will be time, let's move it to the icebox and evaluate next time.

@stellarmagnet stellarmagnet modified the milestones: Sprint B2, Sprint B3 Dec 6, 2019
@javieralaves javieralaves modified the milestones: Sprint B3, Sprint B2 Dec 16, 2019
@stellarmagnet stellarmagnet removed this from the Sprint B3 milestone Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ottodevs ottodevs

Labels
housekeeping General clean-up tasks and things related to making our repo super pretty and easy to use.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] 588 replace test helpers imports AutarkLabs/open-enterprise
4 participants
@stellarmagnet @ottodevs @Quazia @javieralaves