-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed require statement in setDistribution and improved testing coverage #1290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One note. I think this should probably change, but I'm not 100% sure, so I'm not marking as "request changes." I'm also not marking as "approved" because I want someone with more contract experience to sign off on this. @topocount @Quazia @ottodevs, can one of you take a look, please?
Just a note: Edit: After clarifying with @topocount , let's target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please @PeterMPhillips I am sorry we didn't warn you about this test-helpers
messing that probably confused you, that is one of the reasons we are trying to get rid of it, so it is really important to avoid introducing regressions into our codebase by trying to use it again.
If you are experiencing some kind of issue, please ask us to help with that.
I suggest reverting all these changes, rebasing from latest dev
taking care of looking at the Allocations.test.js
that has the correct test format and imports, and focus into adding the test cases you need on this file... you should not experience any import error then.
Also avoid modifying Allocations.sol
since that code is certified and frozen right now... If we find a critical issue on it, I think it is better tell that in our channels and discuss about the fixes before trying to add the change directly.
I close here in favour of: #1282 Good work overall! I am sorry but things were a bit messed with the different branches. |
Also did
npm link
on the tps-helpers package which may have caused the errors @topocount was seeing