New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Projects: update contracts for audits #1222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadoh
force-pushed
the
web3/projects
branch
2 times, most recently
from
September 5, 2019 16:51
1303373
to
cd3ea93
Compare
chadoh
commented
Sep 5, 2019
chadoh
force-pushed
the
web3/projects
branch
2 times, most recently
from
September 17, 2019 00:51
0636605
to
47e4271
Compare
Since this seems a huge PR I will wait for it to be "Ready for review" and hopefully cleaned a bit |
chadoh
force-pushed
the
web3/projects
branch
from
September 24, 2019 14:55
5fc5242
to
81c3a60
Compare
chadoh
changed the base branch from
dev
to
update-client-to-0.8-experimental
September 24, 2019 14:56
chadoh
force-pushed
the
web3/projects
branch
2 times, most recently
from
September 25, 2019 14:37
4fa0a77
to
d01c20b
Compare
chadoh
force-pushed
the
update-client-to-0.8-experimental
branch
7 times, most recently
from
September 26, 2019 21:03
1788052
to
4bcea2f
Compare
chadoh
force-pushed
the
web3/projects
branch
2 times, most recently
from
September 26, 2019 21:22
9dc695e
to
a36c0a5
Compare
chadoh
force-pushed
the
update-client-to-0.8-experimental
branch
from
September 27, 2019 02:27
4bcea2f
to
8bd084a
Compare
chadoh
force-pushed
the
web3/projects
branch
from
September 27, 2019 17:50
4da0730
to
9c01f3d
Compare
chadoh
changed the base branch from
update-client-to-0.8-experimental
to
dev
September 27, 2019 17:50
chadoh
force-pushed
the
web3/projects
branch
from
September 30, 2019 14:04
02343ff
to
4dc736a
Compare
chadoh
force-pushed
the
web3/projects
branch
2 times, most recently
from
October 2, 2019 01:07
b1deda5
to
28e6b2b
Compare
ottodevs
added
app: projects
contracts
Involves changes to solidity files
mainnet
labels
Oct 2, 2019
chadoh
force-pushed
the
web3/projects
branch
4 times, most recently
from
October 2, 2019 21:09
774626e
to
1326728
Compare
Required fixing some stylelint issues
This seems like a logical order to think about these events happening in
* add fulfillers to submission/work object so that we can * add fulfillmentAmounts to reviewSubmissions call. * Listen for ActionPerformed and update `workSubmission` with this data * Guard against events being processed out of order, in ActionPerformed and in BountyFulfilled
* dev: Projects: get dev working Proposal for git clean:build that satisfies everyone wishes package script improvements
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the updated contract for Projects, and all associated changes.
Changes required for mainnet launch
BountyAdded
with new paramregistryId
; update return values in event handlerAssignmentRejected
initialize
no longer acceptsdefaultToken
; in template, remove everything related todefaultToken
start:dev
, as intest.sh
, deployStandardBounties
contract to local blockchainloadIssueData
; no longer returnstoken
ordataHash
getSettings
; returnsbountiesRegistry
instead ofsettings.bountyAllocator
reviewSubmission
, now requires a sixth param,tokenAmounts
submitWork
, which has been removed fromProjects.sol
, by using StandardBounties'fulfillBounty
and listening for events from StandardBountiesgetSubmissionLength
, use StandardBountiesgetBounty
insteadgetSubmission
, use StandardBountiesgetBounty
instead. Inside the struct returned bygetBounty
there is afulfillments
array which contains all submissions & submitter infoaddBounties
; inputtokenBounties
changed totokenTypes
Required for mainnet, but needs integration with some other in-progress work once it's all on dev
Post launch improvements
BountyRemoved
AwaitingSubmissions
getRepo
; useopenIssueCount
updateBounty
removeBounties
addBountiesNoAssignment