Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects: update contracts for audits #1222

Merged
merged 33 commits into from Oct 3, 2019
Merged

Projects: update contracts for audits #1222

merged 33 commits into from Oct 3, 2019

Conversation

chadoh
Copy link
Collaborator

@chadoh chadoh commented Sep 5, 2019

This contains the updated contract for Projects, and all associated changes.

Changes required for mainnet launch

  • updated event BountyAdded with new param registryId; update return values in event handler
  • new event AssignmentRejected
  • initialize no longer accepts defaultToken; in template, remove everything related to defaultToken
  • when running start:dev, as in test.sh, deploy StandardBounties contract to local blockchain
  • update loadIssueData; no longer returns token or dataHash
  • update getSettings; returns bountiesRegistry instead of settings.bountyAllocator
  • update reviewSubmission, now requires a sixth param, tokenAmounts
  • implement submitWork, which has been removed from Projects.sol, by using StandardBounties' fulfillBounty and listening for events from StandardBounties
  • removed getSubmissionLength, use StandardBounties getBounty instead
  • removed getSubmission, use StandardBounties getBounty instead. Inside the struct returned by getBounty there is a fulfillments array which contains all submissions & submitter info
  • when listening for events from StandardBounties, ignore all events for bountyIds that we don't care about
  • update addBounties; input tokenBounties changed to tokenTypes

Required for mainnet, but needs integration with some other in-progress work once it's all on dev

  • ensure switching bounty token functions correctly
  • remove hard-coded StandardBounties address from PlanningKit.sol

Post launch improvements

  • handle new event BountyRemoved
  • handle new event AwaitingSubmissions
  • update getRepo; use openIssueCount
  • use updateBounty
  • use removeBounties
  • use addBountiesNoAssignment
  • unassign user when application or submission rejected, so same user can apply to work again

@chadoh chadoh force-pushed the web3/projects branch 2 times, most recently from 1303373 to cd3ea93 Compare September 5, 2019 16:51
@chadoh chadoh force-pushed the web3/projects branch 2 times, most recently from 0636605 to 47e4271 Compare September 17, 2019 00:51
@ottodevs
Copy link
Member

Since this seems a huge PR I will wait for it to be "Ready for review" and hopefully cleaned a bit

@chadoh chadoh changed the base branch from dev to update-client-to-0.8-experimental September 24, 2019 14:56
@chadoh chadoh force-pushed the web3/projects branch 2 times, most recently from 4fa0a77 to d01c20b Compare September 25, 2019 14:37
@chadoh chadoh force-pushed the update-client-to-0.8-experimental branch 7 times, most recently from 1788052 to 4bcea2f Compare September 26, 2019 21:03
@chadoh chadoh force-pushed the web3/projects branch 2 times, most recently from 9dc695e to a36c0a5 Compare September 26, 2019 21:22
@chadoh chadoh force-pushed the update-client-to-0.8-experimental branch from 4bcea2f to 8bd084a Compare September 27, 2019 02:27
@chadoh chadoh changed the base branch from update-client-to-0.8-experimental to dev September 27, 2019 17:50
@chadoh chadoh force-pushed the web3/projects branch 2 times, most recently from b1deda5 to 28e6b2b Compare October 2, 2019 01:07
@ottodevs ottodevs added app: projects contracts Involves changes to solidity files mainnet labels Oct 2, 2019
@chadoh chadoh force-pushed the web3/projects branch 4 times, most recently from 774626e to 1326728 Compare October 2, 2019 21:09
Chad Ostrowski added 8 commits October 2, 2019 21:35
Required fixing some stylelint issues
This seems like a logical order to think about these events happening in
* add fulfillers to submission/work object so that we can
* add fulfillmentAmounts to reviewSubmissions call.
* Listen for ActionPerformed and update `workSubmission` with this data
* Guard against events being processed out of order, in ActionPerformed
  and in BountyFulfilled
@chadoh chadoh marked this pull request as ready for review October 3, 2019 02:19
@chadoh chadoh requested review from a team as code owners October 3, 2019 02:19
@ghost ghost requested a review from Quazia October 3, 2019 02:19
* dev:
  Projects: get dev working
  Proposal for git clean:build that satisfies everyone wishes
  package script improvements
@chadoh chadoh mentioned this pull request Oct 3, 2019
@chadoh chadoh merged commit 78ad004 into dev Oct 3, 2019
@chadoh chadoh deleted the web3/projects branch October 3, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: projects contracts Involves changes to solidity files mainnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants