Filterbar context #1693
Open
Filterbar context #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prise into filterbar-overflow
Moved outside of main FilterBar component, no more automatic closing of DropDowns when en option has been selected.
…prise into filterbar-overflow-cleanup
…erbar-overflow-cleanup
…prise into filterbar-overflow-cleanup
Because that's where all FilterBar modules live.
ActiveFilters is that little div below FilterBar dropdowns displaying all (and only) active filters: [tag X]. This change allows all current Options to use 'name' property instead of variety like 'name', 'title', etc. All future filters should follow this trait.
Also, 'filters' are now called 'activeFilters' eveywhere, for clarity.
…erbar-overflow-cleanup
for "mini filterbar". Also, activeIndex is now a simple int.
…o filter by upon switching to Issues tab
Problem fixed: resetting filters with setActiveFilters(INIT_FILTERS)
didn't work, setActiveFilters({...INIT_FILTERS}) didn't work either.
Cause: that initial structure was copied shallowly. Therefore filters
enabled with toggle() survived. Fix:
setActiveFilters(initFilters())
This function returns bran new structure.
We need to prevent un-rendering <Issues />, as this causes all of its state to be re-initialized once it's rendered again. This is exactly what was happening when we were returning early from the IssuesQuery component when it was in the `loading` state.
Instead of asking IssuesQuery to display different components depending on what state the query is in - loading, error, etc. Issues got rendered only after data has been returned - which meant destroying it every now and then, and that was unhelpful for number of hooks rendered, remembering already downloaded issues, etc. Now Issues component is always rendered and it itself decides whether to display list of Issues (when data is finally present) or messages about state of the query (loading/error, etc).
* dev: Changed all 'Review' texts to 'View' Rewards/MyRewards: add date to claimed status CODEOWNERS: fix capitalization of team names Rewards/ViewReward: add status info Rewards/ViewReward: changes after rebase Rewards/ViewReward: add status information Rewards/ViewReward: dynamic panel title Show SubmitWork option to issue owner only Projects/FundIssues: only validate after blur Projects/FundForm: improve "can't be zero" errors Projects: Context menu sentence case Dot Voting: Fix Label color Projects: fix frontend stub Rewards/My Rewards: add icons to "status" Rewards/My Rewards: add icons to "status" Rewards: improve error message for non-transferable assets
Neither the MiniFilterBar nor the full FilterBar were displaying on screens 514px wide exactly
Do not show on IssueDetail page
chadoh
force-pushed
the
filterbar-context
branch
from
ece86b8
to
7c1af58
Compare
The props that were passed into TextFilter were not used anywhere outside of the component, and can therefore live within it instead.
chadoh
force-pushed
the
filterbar-context
branch
3 times, most recently
from
38968b3
to
5b05b35
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes description are in commit messages. Short version would be: reorganized Issues, separated Filtering Options and reused them in new Filtering Panel (for mobile users), added Filtering context, cleaned up Projects...