Implement dynamic url for etherscan links and use IdentityBadge from @aragon/ui #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2019
ottodevs
changed the title
ottodevs
force-pushed
the
317-address-badge
branch
from
d7b7e3c
to
c9cd79b
Compare
Pull Request Test Coverage Report for Build 1605
💛 - Coveralls |
|
Can you pull from dev to resolve the coveralls issue? |
Quazia
approved these changes
Mar 15, 2019
There was a problem hiding this comment.
LGTM, the badges look a little weird on the next line I'd probably change them to be inline but the way you've got it syncs with the design. Maybe something to revisit? Also since we're only testing in on localhost we should make sure it works on Rinkeby when we do that but it looks like it should work idk why it wouldn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #182 and #317