Skip to content

Commit

Permalink
update i18n
Browse files Browse the repository at this point in the history
  • Loading branch information
Sneezry committed Feb 18, 2018
1 parent cca9470 commit 23e50ab
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions _locales/en/messages.json
Expand Up @@ -104,7 +104,7 @@
"description": "Confirmm Passphrase."
},
"confirm_delete" : {
"message": "Are you sure you want to delete this code? This action cannot be undone.",
"message": "Are you sure you want to delete this item? This action cannot be undone.",

This comment has been minimized.

Copy link
@mymindstorm

mymindstorm Feb 19, 2018

Member

This is the only place that codes are referred to as an 'item', while in every other message they are referred to as 'secrets'

This comment has been minimized.

Copy link
@Sneezry

Sneezry Feb 19, 2018

Author Member

You are right, I will change it to 'secret'

"description": "Remove entry confirmation"
},
"security_warning": {
Expand Down Expand Up @@ -160,7 +160,7 @@
"description": "Local Time is Too Far Off"
},
"remind_backup": {
"message": "Do you have a backup for your secrets? Don't wait until it's too late!",
"message": "NEVER REINSTALL THE EXTENSION TO TRY TO FIX ANY ISSUE, OR YOU WILL LOSE ALL YOUR DATA! Do you have a backup for your secrets? Don't wait until it's too late!",

This comment has been minimized.

Copy link
@mymindstorm

mymindstorm Feb 19, 2018

Member

Losing data on reinstalling is Chrome specific. Maybe we should move this to a message that only appears one time after install?

This comment has been minimized.

Copy link
@mymindstorm

mymindstorm Feb 19, 2018

Member

one time after install? To make sure that users see it. I've also put a big warning on the support link

This comment has been minimized.

Copy link
@Sneezry

Sneezry Feb 19, 2018

Author Member

Good idea. We can just open the link when the user first install the extension in Chrome.

This comment has been minimized.

Copy link
@Sneezry

Sneezry Feb 19, 2018

Author Member

Could you please open a blacklog to track this task? I will remove the alert from here.

"description": "Remind Backup"
},
"capture_failed": {
Expand Down
8 changes: 4 additions & 4 deletions _locales/zh_CN/messages.json
Expand Up @@ -8,7 +8,7 @@
"description": "Extension Short Name."
},
"extDesc": {
"message": "适用于Google身份验证器及战网安全令",
"message": "身份验证器用以在浏览器中生成二步认证代码",
"description": "Extension Description."
},
"added": {
Expand Down Expand Up @@ -44,11 +44,11 @@
"description": "OK."
},
"yes": {
"message": "Yes",
"message": "",
"description": "Yes."
},
"no": {
"message": "No",
"message": "",
"description": "No."
},
"err_acc_sec": {
Expand Down Expand Up @@ -188,7 +188,7 @@
"description": "Scale"
},
"export_info": {
"message": "将此文本保存至安全的地方来备份你的密钥。想要将账号添加至其他应用?请点击账号右上角隐藏的图标。",
"message": "警告:所有备份均未加密。想要将账号添加至其他应用?请点击账号右上角隐藏的图标。",
"description": "Export menu info text"
},
"download_backup": {
Expand Down

0 comments on commit 23e50ab

Please sign in to comment.