Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement includeTransactions function into Get Subscription Request #287

Closed
wants to merge 6 commits into from

Conversation

zenphp
Copy link

@zenphp zenphp commented Feb 14, 2018

The implements the includeTransactions property and behavior of the ARBGetSubscriptionRequest as documented in https://developer.authorize.net/api/reference/#recurring-billing-get-subscription

Addresses #280

@zenphp zenphp changed the title Dev 1.9.4 Implement includeTransactions function into Get Subscription Request Feb 14, 2018
/**
* @property \net\authorize\api\contract\v1\TransactionDetailsType[]
*/
private $arbTransactions = null;
Copy link
Contributor

@ashtru ashtru Feb 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be of a new type \net\authorize\api\contract\v1\ArbTransactionType[] . New class for this type required.

@ashtru
Copy link
Contributor

ashtru commented Feb 16, 2018

Thanks a lot for the PR, @zenphp !👍
IncludeTransactions has been a popular merchant demand, and we are working on making it available through the SDK.
Since some of the request/response classes are auto-generated, I had to add some more files, and I have raised a pull request for the same. We will release this change very soon.

@ashtru ashtru closed this Feb 18, 2018
@ashtru
Copy link
Contributor

ashtru commented Feb 22, 2018

includeTransactions has been added to the ARBGetSubscription request as part of the latest release!
Kindly change your composer.json to use version 1.9.5 of authorizenet/authorizenet similar to the sample code composer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants