Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

location service offset #67

Closed
Spiritreader opened this issue Nov 27, 2019 · 2 comments
Closed

location service offset #67

Spiritreader opened this issue Nov 27, 2019 · 2 comments

Comments

@Spiritreader
Copy link
Member

Spiritreader commented Nov 27, 2019

Hi,

it would be great to be able to set a custom offset that shifts the sunset and sunrise times dependent on the automated location service.

With multiple night light and dark theme applications I found that for my preference, it often switches too early.
Preferrably, I would like to switch themes a few minutes / hours after sunrise or sunset. However I also don't want to miss out of having the sunrise and sunset times calculated automatically.

I'd like to propose changes which I have already worked on, as I think this contribution increases QoL a lot, especially for users that are already so picky that they use an auto theme switcher ;)

The way this is implemented is as follows

Presently it looks like this:
grafik

As soon as the location box is ticked, a new set of controls will appear that will either allow a negative or positive offset.

I've tried to adhere to the UI style you used, as I didn't want to disrupt it.

As for how the offset application works: Two offset integers are created in the Settings database, which will be applied each time the location service polls for a new time. Pressing the set button in the GUI will also trigger this.

It would be great if we can start a dialogue on whether it would be possible to merge this.

A pull request will follow shortly which I will reference to this issue.

Thank you!

@Armin2208
Copy link
Member

❤️🔥

@Spiritreader
Copy link
Member Author

Merged. Thanks Armin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants