Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install skip qigen(windows) #309

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Install skip qigen(windows) #309

merged 3 commits into from
Aug 31, 2023

Conversation

qwopqwop200
Copy link
Collaborator

qigen currently does not support windows. Therefore, we made it so that qigen is not installed on Windows.

Currently, I can make Windows generate qigen's backend.cpp, but pytorch fails to compile backend.cpp.

@PanQiWei
Copy link
Collaborator

Hi @qwopqwop200 , thank you for the fixing, it looks good to me.

Here is one topic I want to futher discuss that we may do in another PR:

Can we treat Qigen as a third party package so that we can optionally depend on it when install autog-gptq like using pip install auto-gptq[qigen]. The reason is p = int(subprocess.run("cat /proc/cpuinfo | grep cores | head -1", shell=True, check=True, text=True, stdout=subprocess.PIPE).stdout.split(" ")[2])'s result is highly depend on the CPU what we have at hand, and if we pre-build the wheels, it may use a small value like 8, while our users may have an advanced CPU with 32 or even 64 cores.

@PanQiWei PanQiWei merged commit 1339db3 into main Aug 31, 2023
@qwopqwop200 qwopqwop200 deleted the install-skip-qigen(windows) branch August 31, 2023 12:51
@fxmarty
Copy link
Collaborator

fxmarty commented Oct 20, 2023

Qiwen breaks the installation from source on Linux, see #333. AutoGPTQ not having a CI is kind of a big issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants