Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix non-unique instance id in the node #798

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

wangxye
Copy link
Contributor

@wangxye wangxye commented Dec 5, 2023

fixes: #787

change:

  1. fix non-unique instance id in the node;

Signed-off-by: wangxye <xuanyewang.cs@gmail.com>
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #798 (22cb0b5) into main (2f5f5ce) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 66.66%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #798      +/-   ##
============================================
+ Coverage     57.60%   57.62%   +0.02%     
- Complexity     1229     1231       +2     
============================================
  Files           132      132              
  Lines          8107     8109       +2     
  Branches        744      745       +1     
============================================
+ Hits           4670     4673       +3     
  Misses         3034     3034              
+ Partials        403      402       -1     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 55.13% <66.66%> (-0.01%) ⬇️
RocketMQ Proxy 42.73% <ø> (+0.12%) ⬆️
RocketMQ Store 76.89% <ø> (ø)
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)
Files Coverage Δ
.../controller/server/store/DefaultMetadataStore.java 65.60% <66.66%> (-0.09%) ⬇️

... and 1 file with indirect coverage changes

@wangxye wangxye merged commit 99c0fb7 into AutoMQ:main Dec 5, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-unique node instance_id will be duplicated
2 participants