Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Good first issue] Add #asyncClose to LocalLog #1100

Closed
superhx opened this issue Apr 8, 2024 · 3 comments
Closed

[Good first issue] Add #asyncClose to LocalLog #1100

superhx opened this issue Apr 8, 2024 · 3 comments
Assignees
@Shuimo03
Labels
good first issue Good for newcomers

Comments

@superhx
Copy link
Collaborator

superhx commented Apr 8, 2024 •
edited
Loading

Introduce an #asyncClose method to both LocalLog and ElasticLocalLog. This approach is preferred over altering the signature of the existing #close method, as it helps prevent future merge conflicts.
@superhx superhx added the good first issue Good for newcomers label Apr 8, 2024
@Shuimo03
Copy link

hi, Can I pick this up?

@superhx
Copy link
Collaborator Author

superhx commented Apr 23, 2024

hi, Can I pick this up?

Of course, you're welcome to submit a PR

@DaniilRoman DaniilRoman mentioned this issue Jul 3, 2024
Merged
3 tasks
@DaniilRoman
Copy link
Contributor

Hey there 👋
Since the ticket hasn't had any updated for the months, I decided to take it over, I hope it's fine 🙏

@superhx superhx closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shuimo03 Shuimo03

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@superhx @Shuimo03 @DaniilRoman