Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Good first issue] argparse4j downgraded to 0.7.0 #1101

Closed
superhx opened this issue Apr 8, 2024 · 6 comments · Fixed by #1566
Closed

[Good first issue] argparse4j downgraded to 0.7.0 #1101

superhx opened this issue Apr 8, 2024 · 6 comments · Fixed by #1566
Labels
good first issue Good for newcomers

Comments

@superhx
Copy link
Collaborator

superhx commented Apr 8, 2024 •
edited
Loading

  • argparse4j downgraded from 0.9.0 to 0.7.0
  • revert the ArgumentParses modification kafka_3_7_0...main
    image

Please keep the old code format to avoid merge conflict when merging from kafka/trunk.
Check kafka_3_7_0...main to downgrade argparse4j
@superhx superhx added the good first issue Good for newcomers label Apr 8, 2024
@Shuimo03
Copy link

hi, Can I pick this up?

@superhx
Copy link
Collaborator Author

superhx commented Apr 23, 2024

hi, Can I pick this up?

Of course, you're welcome to submit a PR

Shuimo03 added a commit to Shuimo03/automq that referenced this issue Apr 27, 2024
@Shuimo03
feat(AutoMQ#1101): argparse4j downgraded to 0.7.0
38121c7
@Shuimo03 Shuimo03 mentioned this issue Apr 27, 2024
Closed
Shuimo03 added a commit to Shuimo03/automq that referenced this issue May 9, 2024
@Shuimo03
feat(AutoMQ#1101): argparse4j downgraded to 0.7.0
5d1db0c
@Amitbhave
Copy link
Contributor

Is this still in progress, or can I take this over?

@superhx superhx assigned Amitbhave and unassigned Amitbhave and Shuimo03 Jul 11, 2024
@Shuimo03
Copy link

Sorry I haven't had time lately, I apologize for the PR!

@Amitbhave
Copy link
Contributor

@Shuimo03 , I had picked up this issue now. Is it fine with you?

@Amitbhave Amitbhave mentioned this issue Jul 12, 2024
Merged
@Shuimo03
Copy link

@Amitbhave yes, i am fine, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Downgrade argparse4j to 0.7.0 Amitbhave/automq
3 participants
@superhx @Amitbhave @Shuimo03