No options required #136
No options required #136
Conversation
lbargaoanu
force-pushed
the
no_options
branch
9 times, most recently
from
9be0008
to
40e65a3
Compare
| if (services.Any(sd => sd.ServiceType == typeof(IMapper))) | ||
| return services; | ||
|
|
||
| var sd = services.FirstOrDefault(sd => sd.ServiceType == typeof(IConfigurationProvider)); |
There was a problem hiding this comment.
This is what the Options stuff does, though. Why create our own factory, and leverage something out-of-the-box instead?
There was a problem hiding this comment.
It's not out of the box :) You have to add a package reference for how many lines of code, maybe five? I don't see the point.
There was a problem hiding this comment.
I don't mind a package reference in a library that is meant to support a specific package reference though, and in a way that is more or less the design of what this factory does.
There was a problem hiding this comment.
I think it just makes things more difficult to understand. Abstraction over clarity. My initial impression was that it might enable some client use cases, but I guess not.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
It seems pretty basic to me.