Allow simple MapFrom-s to pass validation #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not following how this fixes the original issue - shouldn't the MapFrom have fixed the configuration problem in the derived map? Or it's because it's looking at source members. |
|
The mapping works. It's not valid because it validates the source and that extra check that I removed. I guess a more general solution would be to consider mapped all source members referenced in the MapFrom. |
|
Well, let's see if this works for folks. I suspect that most want just the |
jbogard
approved these changes
Jul 5, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2172. This won't work for more complicated expressions. If you feel it's inconsistent, just close it.