Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mapper.Reset to reset static mapping #2407

Merged
merged 6 commits into from Nov 16, 2017
Merged

Add Mapper.Reset to reset static mapping #2407

merged 6 commits into from Nov 16, 2017

Conversation

jbogard
Copy link
Member

@jbogard jbogard commented Nov 16, 2017

No description provided.

@jbogard jbogard added this to the 6.2.1 milestone Nov 16, 2017
@jbogard
Copy link
Member Author

jbogard commented Nov 16, 2017

@lbargaoanu thoughts?

@lbargaoanu
Copy link
Member

Do we really have to? :) I mean you solved the issue with the DI package, right?

@jbogard
Copy link
Member Author

jbogard commented Nov 16, 2017

Kinda solved it, but I think these are two different issues - you can't reset the static mapping, and the ability to configure the DI extension's behavior.

If you wanted to keep the static behavior but still do services.AddAutoMapper then Reset would give you that.

@lbargaoanu
Copy link
Member

Maybe some warning in the XML docs? Not intended for production?

@jbogard
Copy link
Member Author

jbogard commented Nov 16, 2017 via email

@jbogard jbogard merged commit 146be21 into master Nov 16, 2017
@jbogard jbogard deleted the MapperReset branch November 16, 2017 14:34
@lock
Copy link

lock bot commented May 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants