New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove iterators and replace with for_each, parallel_for_each, parallel_reduction, ... #434
Comments
particle deletion will probably become more complicated that way and probably needs an additional method, e.g., |
or, probably also needed for the LC-reference-cell container (tentative name) just flag a particle as deleted and delete them only later. |
I will add a parallel_for_each in a future commit for #626 Additionally, examples (eg. md-flex) will be adapted in a future mr. |
I would actually like to use |
Camel cased or with underscore? so forEachParallel or forEach_parallel ? |
Right, probably |
On the topic of reductions: |
Good question. I would assume reductions only of a subset of particles are also of interest. |
I know how to trigger your sense of creating Arbeitsbeschaffungsmaßnahmen and should probably stop right? xD |
Should we start to consider templating these? |
I'd say just start implementing them, and when you notice that there is a huge overlap of code try to remove redundancies e.g. via templates or calls to helper functions. |
question: how are parallel foreachs named in kokkos or other codes? does it maybe make sense to use a similar naming scheme? |
parallel_for and parallel_reduce I would honestly keep it consistent with the rest of AutoPas. |
Is your feature request related to a problem? Please describe.
Needed for proper kokkos support.
Also makes our lives easier
The text was updated successfully, but these errors were encountered: