Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VerletClusterLists should use a proper CellBorderAndFlagManager when possible #437

Closed
SteffenSeckler opened this issue Apr 1, 2020 · 2 comments
Closed

VerletClusterLists should use a proper CellBorderAndFlagManager when possible #437

SteffenSeckler opened this issue Apr 1, 2020 · 2 comments
Labels
optimization not a bug, but can optimize speed

Comments

@SteffenSeckler
Copy link
Member

SteffenSeckler commented Apr 1, 2020 •
edited

Is your feature request related to a problem? Please describe.
Currently, we use the UnknowingCellBorderAndFlagManager for the VerletClusterLists.
This can be optimized.

Describe the solution you'd like
Use a proper CellBorderAndFlagManager
This will make it possible to optimized, especially, iteration over HaloParticles.

Describe alternatives you've considered
More or less invalid, if #434 is implemented.

Additional context
workaround (using the Unknowing...) was introduced in #430
@SteffenSeckler SteffenSeckler added the optimization not a bug, but can optimize speed label Apr 1, 2020
@SteffenSeckler SteffenSeckler mentioned this issue Apr 1, 2020
Merged
21 tasks
@FG-TUM
Copy link
Member

FG-TUM commented Mar 2, 2023

As of #712 VCL doesn't even use the UnknowingCellBorderAndFlagManager anymore as it is not relevant anymore for iterators.

@FG-TUM FG-TUM mentioned this issue Mar 2, 2023
Merged
7 tasks
@FG-TUM
Copy link
Member

FG-TUM commented Feb 17, 2024 •
edited

Should have been closed with the merge of #712

@FG-TUM FG-TUM closed this as completed Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
optimization not a bug, but can optimize speed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FG-TUM @SteffenSeckler