Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up documentation headings globally in parent package #485

Merged
merged 11 commits into from Jun 23, 2023
Merged

Clean up documentation headings globally in parent package #485

merged 11 commits into from Jun 23, 2023

Conversation

benwandrew
Copy link
Collaborator

Description

Type of change

  • docs: Documentation only changes

@benwandrew benwandrew linked an issue Jun 23, 2023 that may be closed by this pull request
Clean up documentation headings globally #482
Closed
younesStrittmatter
younesStrittmatter approved these changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@younesStrittmatter younesStrittmatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
We should have stuff like this documented somewhere as style guide (I think under contributions makes sense)

@benwandrew
Copy link
Collaborator Author

Looks good! We should have stuff like this documented somewhere as style guide (I think under contributions makes sense)

good idea, just created a small PR to add this in index.md under contribute

@benwandrew benwandrew added this pull request to the merge queue Jun 23, 2023
Merged via the queue into main with commit ab743aa Jun 23, 2023
14 checks passed
@benwandrew benwandrew deleted the docs/clean-up-documentation-headings-globally branch June 23, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesStrittmatter younesStrittmatter younesStrittmatter approved these changes

@musslick musslick Awaiting requested review from musslick

@hollandjg hollandjg Awaiting requested review from hollandjg

@chadcwilliams chadcwilliams Awaiting requested review from chadcwilliams

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up documentation headings globally
2 participants
@benwandrew @younesStrittmatter