Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize correctly named variable: forecast_df_folds, not forecast #98

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Conversation

cgobat
Copy link
Contributor

@cgobat cgobat commented Mar 26, 2023

This PR should fix #97 (and, by extension, facebook/prophet#2392).

During the instantiation and construction of Prophet-based models in __init__.py (lines ~535-577), there is currently a forecasts = None initialization that is never used. I suspect this variable was intended to be forecast_df_folds, which is the variable used later for the forecasts, and matches the pattern used in the auto_SARIMAX model instantiation. If forecast_df_folds is not initialized to None, it will cause problems later on if an exception is encountered during the try/except. This change simply renames that forecasts variable to forecast_df_folds to address this.

@AutoViML
Copy link
Owner

AutoViML commented May 17, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with prophet cause variables to be left undefined
2 participants