Initialize correctly named variable: forecast_df_folds
, not forecast
#98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #97 (and, by extension, facebook/prophet#2392).
During the instantiation and construction of Prophet-based models in
__init__.py
(lines ~535-577), there is currently aforecasts = None
initialization that is never used. I suspect this variable was intended to beforecast_df_folds
, which is the variable used later for the forecasts, and matches the pattern used in theauto_SARIMAX
model instantiation. Ifforecast_df_folds
is not initialized toNone
, it will cause problems later on if an exception is encountered during the try/except. This change simply renames thatforecasts
variable toforecast_df_folds
to address this.