This repository has been archived by the owner on Jun 13, 2020. It is now read-only.
backend ttls! #150
Merged
backend ttls! #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wattdave
reviewed
Oct 22, 2017
| @@ -249,11 +249,12 @@ def dict_unicodeize(some_dict): | |||
| return some_dict | |||
|
|
|||
|
|
|||
| def diff_dict(dict1, dict2): | |||
| def diff_dict(dict1, dict2, ignore_missing=False): | |||
There was a problem hiding this comment.
I needed something similar for the CloudOS health checker, and used the DeepDiff library. YMMV.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings #101, #86, and #110 into play. Ad-Hoc backend creation is now no longer a thing, however it will still work for Generic secrets (albeit with a deprecation warning). It will no longer work for UserPass. Note that you can only adjust the mount tune parameters on Vault versions 0.7.0 and above.
This PR also introduces a slightly tighter linking between certain flavours of
Resourceand appropriateVaultBackendimplementations. Not super happy about it, and I think that it should probably get cleaned (maybe making backends full-onResourceimplementations).Before this gets merged I want to do the following