This repository has been archived by the owner on Jun 13, 2020. It is now read-only.
handle another^H^H^H^H^H^H^Hmore backwards compatibility regressions #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regression was in the ability to detect whether or not backends have changed or not. There is a likely future optimization in the
Backend.fetch
function but outside the scope of this PR.Also added to the
diff
integration test to make sure we test theNOOP
case.And I have no idea how line 25 of the
Makefile
ever worked before but it works now (I'm assuming something on thecoverage
tool changed).cc @fortinmath