Skip to content
This repository has been archived by the owner on Jun 13, 2020. It is now read-only.

handle another^H^H^H^H^H^H^Hmore backwards compatibility regressions #164

Merged

Conversation

otakup0pe
Copy link
Contributor

@otakup0pe otakup0pe commented Nov 14, 2017

This regression was in the ability to detect whether or not backends have changed or not. There is a likely future optimization in the Backend.fetch function but outside the scope of this PR.

Also added to the diff integration test to make sure we test the NOOP case.

And I have no idea how line 25 of the Makefile ever worked before but it works now (I'm assuming something on the coverage tool changed).

cc @fortinmath

  • confirm if this regression is in ldap/userpass
  • better test coverage on diff

@otakup0pe otakup0pe changed the title handle another backwards compatibility regression handle another^H^H^H^H^H^H^Hmore backwards compatibility regressions Nov 17, 2017
@otakup0pe
Copy link
Contributor Author

I think we now have 💯 test coveage of the diff action which is kind of cool. The last pr also fixes #162 (and we've added a smoke test to capture this scenario)

Copy link
Contributor

@ericfode ericfode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@otakup0pe otakup0pe merged commit 1789308 into Autodesk:master Nov 17, 2017
@otakup0pe otakup0pe deleted the freedmj/backwards-mount-regression branch November 17, 2017 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants