Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify a given RenderSettings prim when kicking a usd file #1017

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

sebastienblor
Copy link
Collaborator

We add a possible paramMap "render_settings" when loading a usd file. If set, the reader will only pick a RenderSettings prim with this given name. If not set, only the first RenderSettings prim will be considered (currently all would end up being translated to the same arnold options node)

Issues fixed in this pull request
Fixes #1016

@sebastienblor
Copy link
Collaborator Author

In the second commit I added a test (203) that opens several times the same usd file with different params for render_settings .
The test verifies the translated arnold options node has the proper attribute values and camera. It also verifies that when no render settings are provided we exclusively read the first one found during the traverse, instead of reading all of them as before.

Copy link
Contributor

@jhodgson jhodgson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sebastienblor sebastienblor merged commit 06d7e16 into Autodesk:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control which RenderSettings prims is used when reading a usd file
2 participants