Support light linking on instances #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienblor
added
bug
jhodgson
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
In order to resolve light/shadow linking, we call
sceneDelegate->GetCategories(rprim->GetId())to get the list of collections that include the current shape. Then, inApplyLightLinkingwe check which lights were linked to this any of these collections.But in the case of a point instancer (or with instances in general), we should also consider the collections for the instancer node.
In this PR, we append both the collections for the current shape, with the ones of the eventual instancer.
When no instances are found, we avoid copying the collections array and just pass the reference. But in the case of instances with light linking, we compute a new array and append all the required elements.
Adding test_0223 with such a use case, so that it can be tested in both the procedural and the delegate
Issues fixed in this pull request
Fixes #1060