Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Realign accent color and base color #1284

Closed
nfiniteset opened this issue Oct 15, 2018 · 1 comment
Closed

Realign accent color and base color #1284

nfiniteset opened this issue Oct 15, 2018 · 1 comment
Assignees
@wmui51
Labels
2pt theme data
Projects
HIG backlog

Comments

@nfiniteset
Copy link
Contributor

nfiniteset commented Oct 15, 2018 •
edited

  • Replace colorScheme.accentColor* with colorScheme.accentColor. We'll make variations of the accent color using transparency. E.g. the dropdown menu item on hover is a semi-transparent version of the accent color.
  • add colorScheme.baseColor role. Replace references to basics.colors.charcoal600 with the new base color.
@nfiniteset nfiniteset created this issue from a note in HIG backlog (Priorities) Oct 15, 2018
@wmui51 wmui51 moved this from Priorities to In Progress in HIG backlog Oct 17, 2018
@wmui51 wmui51 self-assigned this Oct 17, 2018
@wmui51 wmui51 mentioned this issue Oct 18, 2018
Merged
@wmui51 wmui51 moved this from In Progress to Under review in HIG backlog Oct 18, 2018
@nfiniteset nfiniteset moved this from Under review to Done in HIG backlog Oct 22, 2018
@nfiniteset nfiniteset moved this from Done to Under review in HIG backlog Oct 22, 2018
@nfiniteset
Copy link
Contributor Author

It looks like the surface colors were done but not accent or base colors. See story description above.

@nfiniteset nfiniteset moved this from Under review to Priorities in HIG backlog Oct 22, 2018
@nfiniteset nfiniteset moved this from Priorities to In Progress in HIG backlog Oct 22, 2018
@wmui51 wmui51 moved this from In Progress to Under review in HIG backlog Oct 24, 2018
HIG backlog automation moved this from Under review to Done Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wmui51 wmui51

Labels
2pt theme data
Projects
HIG backlog
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nfiniteset @wmui51