Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiview collaboration chart #124

Merged
merged 4 commits into from
Feb 15, 2018

Conversation

pluehne
Copy link
Contributor

@pluehne pluehne commented Feb 14, 2018

This makes the collaboration chart multiview-capable and adds three views for different time ranges (2 months, 2 years, all data) to choose from.

screenshot from 2018-02-14 14-59-04

First, this extends the chord chart with support for multiple views. Users can switch between these with the view switchers that were previously implemented for history charts.

For this to work, the data file may contain multiple matrices in the same file (one after the other). If the configuration contains multiple entries in the “views” array, these will be mapped to the respective data matrices.

With this modification, the chord chart automatically generates a view switcher and an entity (for instance, organization) selector. The visualization is constantly kept in sync with these inputs.

Further, this adds three views to the collaboration chart along with some demo data for the live demo.

However, the demo data isn’t very interesting to look at and is subject to be replaced at a later point in time.

To Do

  • adjust the SQL queries to produce data in the new format (assigned to @larsxschneider)
  • provide more interesting demo data

Closes #115.

@pluehne
Copy link
Contributor Author

pluehne commented Feb 14, 2018

@larsxschneider: When you adjust the updater report, you might want to think about whether the “two months, two years, all data” granularity makes sense here (haven’t thought much about this yet).

pluehne and others added 4 commits February 15, 2018 14:35
With the view switcher added, the action bar doesn’t just consist of a
button to download the raw data now. For this reason, the action bar
shouldn’t be hidden just because the raw data button is hidden.

While this will show the action bar even if it is empty, we currently
don’t have a use case where both the view switcher and the download
button are hidden at the same time.
This extends the chord chart with support for multiple views. This will
be used to visualize collaboration across multiple time ranges. Users
can switch between these with the view switchers that were previously
implemented for history charts.

For this to work, the data file may contain multiple matrices in the
same file (one after the other). If the configuration contains multiple
entries in the “views” array, these will be mapped to the respective
data matrices.

With this modification, the chord chart automatically generates a view
switcher and an entity (for instance, organization) selector. The
visualization is constantly kept in sync with these inputs.
This adds three views to the collaboration chart along with some demo
data for the live demo.

The demo data isn’t very interesting to look at and is subject to be
replaced at a later point in time.
@larsxschneider larsxschneider force-pushed the patrick/multiview-collaboration-chart branch from c7360fe to f8beada Compare February 15, 2018 13:35
@codecov-io
Copy link

Codecov Report

Merging #124 into master will decrease coverage by 1.67%.
The diff coverage is 5.45%.

@larsxschneider larsxschneider merged commit e6a5b14 into master Feb 15, 2018
Hubble Enterprise 0.3.0 automation moved this from To Do to Done Feb 15, 2018
@larsxschneider larsxschneider deleted the patrick/multiview-collaboration-chart branch February 15, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants