Don’t jump to top of the page when switching views #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clicks on the view switcher buttons are supposed to be handled by JavaScript in order to switch the active view, bypassing the browser. However, without telling the browser that the click events have been reacted to, it will load the URL as usual. As the view switcher buttons have a “#” placeholder link, this would cause the browser to jump to to the top of the page. This is fixed by returning false in the click event handling functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicks on the view switcher buttons are supposed to be handled by JavaScript in order to switch the active view, bypassing the browser. However, without telling the browser that the click events have been reacted to, it will load the URL as usual. As the view switcher buttons have a
#placeholder link, this would cause the browser to jump to to the top of the page.This is fixed by returning
falsein the click event handling functions.