Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action bar with link to raw data to all charts #85

Merged
merged 1 commit into from Jan 22, 2018

Conversation

pluehne
Copy link
Contributor

@pluehne pluehne commented Jan 17, 2018

This adds an action bar to every chart with a button to download the raw data files in TSV format if existent. The action bar is designed to hold more actions in the future, most notably, a switch for the level of detail in the charts.

Along with the action bar, this commit introduces CSS for buttons.

Note that the action bar is to be considered as a “version 1” design to bring the functionality first, and the layout will probably change in a future release.

For reference, here is a screenshot with the new action bar highlighted:

action-bar

This adds an action bar to every chart with a button to download the raw
data files in TSV format if existent. The action bar is designed to hold
more actions in the future, most notably, a switch for the level of
detail in the charts.

Along with the action bar, this commit introduces CSS for buttons.

Note that the action bar is to be considered as a “version 1” design to
bring the functionality first, and the layout will probably change in a
future release.
@filmaj
Copy link
Contributor

filmaj commented Jan 17, 2018

Looks great... except on the Collaboration chart page, there is a big gap between the sidebars:

screen shot 2018-01-17 at 5 15 44 pm

Happens on both a recent Chrome and Firefox (desktop) version. Looks like it might be caused by the col-aside element in each row being vertically-aligned in the middle?

EDIT: I think it is because the collaboration chart is the only chart that uses the row-centered class, which aligns its items in the middle vertically. Changing the class to just row seems to fix this.

@pluehne
Copy link
Contributor Author

pluehne commented Jan 18, 2018

Admittedly, this was intentional. I first put the action bar into the same col-aside as the other info boxes. However, this required some inelegant code (the action bar would have to be inserted directly before the first existing info box, but then it’s difficult to deal with charts that have no info boxes with descriptive texts).

The second reason for leaving the design like this is that I plan to implement a overhaul of the general layout. We’re starting to get to a stage where we have lots of UI elements that clutter the screen, and where it isn’t easy to quickly grasp what controls/elements belong to which group. That’s why I consider the action bar a “version 1” design (as described above) whose main intent is to bring the functionality.

@filmaj, @larsxschneider: Does that make sense to you? If not, I’m definitely open to adjust the layout for the time being.

@filmaj
Copy link
Contributor

filmaj commented Jan 18, 2018

Sounds fine to me, certainly not a blocker 👍

@larsxschneider
Copy link
Collaborator

Looks good. #87 is minor nit that can be addressed in a separate PR.

@larsxschneider larsxschneider merged commit d31e455 into master Jan 22, 2018
Hubble Enterprise 0.2.0 automation moved this from To Do to Done Jan 22, 2018
@larsxschneider larsxschneider deleted the patrick/action-bar-v1 branch January 22, 2018 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants