Merge pull request #640 from Autodesk/babio/23_3_update

IFC Extension 23.3.0 update

Install/Program Files to Install/bundle/Contents/Resources/ADSKIFCExporterHelp.htm

@@ -237,6 +237,80 @@ <h3>Support Information</h3>
 <h2 id="VersionHistory" name="VersionHistory">Version History</h2>
 
 <div class="versionset">
+	<div class="version">23.3.0.0</div><div class="versioninfo-bullet">
+      <br><p>
+         General:
+			<ul>
+				<li>This is the first version of IFC Exporter for Revit 2023. 
+				<li>It contains a various improvements and bug fixes for the basic Revit 2023. 
+			</ul>	
+       </p>
+	   <br>
+	   <p>
+         Improvements:
+			<ul>
+				<li>Added IFC2x3 Qto sets.
+				<li>Added material shared parameters export.
+				<li>Added the BarRole attribute when exporting IfcReinforcingBars to IFC.
+				<li>Added type entities for rebar and assemblies when exporting to IFC.
+				<li>Added support for exporting predefined types when exporting spaces to IFC4+.
+				<li>Added support of new measure units.
+				<li>Allowed export of rebar with slightly invalid transforms to IFC.
+				<li>Implemented exporting user defined parameters of 'Real' type as IfcReal with Revit display values.
+				<li>Implemented exporting of IfcRailingType entity.
+				<li>Implemented support of all 4 Revit velocity data types on export.
+				<li>Improved display of openings when export or linking in IFC files.
+				<li>Improved calculation of the linked levels elevation.
+				<li>Improved export of IfcPropertyEnumeratedValue.
+				<li>Improved export of insulation and lining as anything.
+				<li>Improved export of projects to IFC that contained family instances with invalid placements.
+				<li>Improved handling entities that don`t have PredefinedType.
+				<li>Improved handling of prohibited characters importing IFC file.
+				<li>Improved how classifications are viewed in certain older external applications when exporting to IFC.
+				<li>Improved linking of IFC files that contained properties with no names.
+				<li>Improved linking of IFC files with slightly self-intersecting profile data.
+				<li>Improved list/bounded/table user defined properties values export for Instances and Types.
+				<li>Improved processing of representation items.
+				<li>Improved support for exporting advanced BReps to IFC if the unofficial IFC4 Design Transfer View is used.
+				<li>Improved the export of the material layers of some IFC4 files with 0 thickness material layers.
+				<li>Improved the export of advanced BReps to the unofficial IFC4 Design Transfer View.
+				<li>Improved the behavior for export of elements split by levels.
+				<li>Improved user defined property set mapping, especially for IFC2x3 entities that previously had no type entity exported.
+				<li>Updated 4x3 enums according to IFC4.3.1.0 Documentation.
+			</ul>
+		</p>
+		<br>
+		<p>
+         Bug Fixes:
+			<ul>
+				<li>Corrected the value for many MEP parameters exported to IFC.
+				<li>Fixed colour for exported pipe fitting.
+				<li>Fixed inconsistent IfcMaterialConstituent naming.
+				<li>Fixed export of a user-defined structural element type.
+				<li>Fixed export of IfcFurnitureType.AssemblyPlace attribute.
+				<li>Fixed export of IFC properties associated with the top-level IfcProject entity.
+				<li>Fixed export of materials from hosted wall sweep.
+				<li>Fixed export of material layer parameters of a ceiling element.
+				<li>Fixed export of user defined properties for roofs.
+				<li>Fixed export of some assemblies to IFC that resulted in orphaned entities.
+				<li>Fixed export of stairs layer name.
+				<li>Fixed IfcExportType for ceilings.
+				<li>Fixed IFC Classification export.
+				<li>Fixed IFCMEASUREWITHUNIT. 
+				<li>Fixed log file creation for linking.
+				<li>Fixed processing of IFCPostalAddress with empty AddressLine.
+				<li>Fixed the calculation of the height parameter for some railings in metric projects when a previous value had been calculated that wasn't applicable to this railing.
+				<li>Fixed the issue when IfcCovering sill's body was exported as Brep instead of SweptSolid.
+				<li>Fixed the processing of openings when exporting a wall as shape aspects (components).
+				<li>Fixed the slope common property set parameter calculation when exporting some stringers to IFC.
+				<li>Fixed Revit Data types export.
+				<li>Removed the use of several Revit built-in parameters when exporting IFC properties that have the same name but are different.
+			</ul>
+		</p>
+		<br>
+	</div>
+	<br>
+
     <div class="version">23.2.5.0</div><div class="versioninfo-bullet">
 		<br><p>
          General:

Install/Program Files to Install/bundle/PackageContents.xml

@@ -1,10 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
-<ApplicationPackage SchemaVersion="1.0" AutodeskProduct="Revit" ProductType="Application" Name="IFC Exporter for Revit" AppVersion="23.2.5.0" Description="This application seamlessly replaces the built-in IFC export capabilities of Revit 2023. " Author="Autodesk" Icon=".\Contents\Resources\IFCExporter.png" AppNameSpace="appstore.exchange.autodesk.com" OnlineDocumentation="http://www.autodesk.com" HelpFile=".\Contents\Resources\ADSKIFCExporterHelp.htm" ProductCode="{40527B9C-60B8-407E-BF56-7AAA67F07ACA}" UpgradeCode="{A27E008E-2278-4F84-BB3B-59C605168900}" SupportedLocales="Enu">
+<ApplicationPackage SchemaVersion="1.0" AutodeskProduct="Revit" ProductType="Application" Name="IFC Exporter for Revit" AppVersion="23.3.0.0" Description="This application seamlessly replaces the built-in IFC export capabilities of Revit 2023. " Author="Autodesk" Icon=".\Contents\Resources\IFCExporter.png" AppNameSpace="appstore.exchange.autodesk.com" OnlineDocumentation="http://www.autodesk.com" HelpFile=".\Contents\Resources\ADSKIFCExporterHelp.htm" ProductCode="{40527B9C-60B8-407E-BF56-7AAA67F07ACA}" UpgradeCode="{A27E008E-2278-4F84-BB3B-59C605168900}" SupportedLocales="Enu">
   <CompanyDetails Name="Autodesk, Inc." Phone=" " Url="http://www.autodesk.com" Email="Revit.apps@autodesk.com" />
   <RuntimeRequirements OS="Win64" Platform="Revit" SeriesMin="R2023" SeriesMax="R2023" />
   <Components Description="2023">
     <RuntimeRequirements OS="Win64" Platform="Revit" SeriesMin="R2023" SeriesMax="R2023" />
-    <ComponentEntry AppName="IFC For Revit 2023" Version="23.2.5" ModuleName="./Contents/2023/IFCExporterUIOverride.addin" AppDescription="IFC For Revit 2023" />
-    <ComponentEntry AppName="IFC For Revit 2023" Version="23.2.5" ModuleName="./Contents/2023/Revit.IFC.addin" AppDescription="IFC For Revit 2023" />
+    <ComponentEntry AppName="IFC For Revit 2023" Version="23.3.0" ModuleName="./Contents/2023/IFCExporterUIOverride.addin" AppDescription="IFC For Revit 2023" />
+    <ComponentEntry AppName="IFC For Revit 2023" Version="23.3.0" ModuleName="./Contents/2023/Revit.IFC.addin" AppDescription="IFC For Revit 2023" />
   </Components>
 </ApplicationPackage>

Install/RevitIFCSetupWix/Product.wxs

@@ -2,7 +2,7 @@
 <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi"
      xmlns:util="http://schemas.microsoft.com/wix/UtilExtension">
 
-   <Product Id="1A9C2C21-2325-42D2-0000-992E73C12300" Name="Revit IFC 2023" Language="1033" Version="23.2.5.0" Manufacturer="Autodesk" UpgradeCode="1A9C2C21-23B8-42D2-0000-992E73C11B3F">
+   <Product Id="1A9C2C21-2330-42D2-0000-992E73C12300" Name="Revit IFC 2023" Language="1033" Version="23.3.0.0" Manufacturer="Autodesk" UpgradeCode="1A9C2C21-23B8-42D2-0000-992E73C11B3F">
       <Package InstallerVersion="200" Compressed="yes" InstallScope="perMachine" />
 
       <MajorUpgrade DowngradeErrorMessage="A newer version of [ProductName] is already installed." />
@@ -112,10 +112,10 @@
                <File Id ="FILE_Ifc_ExternalUI_DLL" Name="IFCExporterUIOverride.dll" Source="$(var.ProjectDir)..\Program Files to Install\IFCExporterUIOverride.dll" KeyPath="yes" />
             </Component>
             <Component Id = "COMP_IFC_Common_DLL" Guid="C7ED4A2C-DCB1-457E-968F-2DDE9993C1B6">
-               <File Id ="FILE_Ifc_Common_DLL" Name="Revit.IFC.Common.dll" Source="$(var.ProjectDir)..\Program Files to Install\Revit.IFC.Common.dll" KeyPath="yes" />
+               <File Id ="FILE_Ifc_Common_DLL" Name="Revit.IFC.Common.dll" Source="$(var.Revit.IFC.Common.TargetDir)Revit.IFC.Common.dll" KeyPath="yes" />
             </Component>
             <Component Id = "COMP_IFC_Import_Core_DLL" Guid="33DEBE0A-57D1-4BFC-BC99-FDA776B6224E">
-               <File Id ="FILE_Ifc_Import_Core_DLL" Name="Revit.IFC.Import.Core.dll" Source="$(var.ProjectDir)..\Program Files to Install\Revit.IFC.Import.Core.dll" KeyPath="yes" />
+               <File Id ="FILE_Ifc_Import_Core_DLL" Name="Revit.IFC.Import.Core.dll" Source="$(var.Revit.IFC.Import.Core.TargetDir)Revit.IFC.Import.Core.dll" KeyPath="yes" />
             </Component>
          <?else?>
             <Component Id = "COMP_IFC_Export_DLL" Guid="D59E44AA-89A3-4CD7-AD9C-8D4D7AC6026B">

Install/RevitIFCSetupWix/RevitIFCSetupWix.wixproj

@@ -6,7 +6,7 @@
     <ProductVersion>3.8</ProductVersion>
     <ProjectGuid>7dfbd495-c588-4c7b-b8f6-5b793adb06f2</ProjectGuid>
     <SchemaVersion>2.0</SchemaVersion>
-    <OutputName>IFC for Revit 2023.2.5.0</OutputName>
+    <OutputName>IFC for Revit 2023.3.0.0</OutputName>
     <OutputType>Package</OutputType>
     <WixTargetsPath Condition=" '$(WixTargetsPath)' == '' AND '$(MSBuildExtensionsPath32)' != '' ">$(MSBuildExtensionsPath32)\Microsoft\WiX\v3.x\Wix.targets</WixTargetsPath>
     <WixTargetsPath Condition=" '$(WixTargetsPath)' == '' ">$(MSBuildExtensionsPath)\Microsoft\WiX\v3.x\Wix.targets</WixTargetsPath>

Install/RevitIFCSetupWix/buildInstaller.bat

@@ -11,9 +11,9 @@ rem It is necessary to add the Wix bin directory to the system path temporarily
 SET PATH=%PATH%;%WixRoot%
 
 candle.exe -dProjectDir=%2 -ext WixUtilExtension %2Product.wxs 
-light.exe -ext WixUtilExtension -out RevitIFC2023.2.5.msi product.wixobj -ext WixUIExtension
+light.exe -ext WixUtilExtension -out RevitIFC2023.3.0.msi product.wixobj -ext WixUIExtension
 
-copy RevitIFC2023.2.5.msi %1..\Releasex64
-del RevitIFC2023.2.5.msi
+copy RevitIFC2023.3.0.msi %1..\Releasex64
+del RevitIFC2023.3.0.msi
 
-echo %1..\Releasex64\RevitIFC2023.2.5.msi
+echo %1..\Releasex64\RevitIFC2023.3.0.msi

Source/IFCExporterUIOverride/IFCAddressInformationUI.xaml.cs

@@ -46,6 +46,7 @@ public partial class IFCAddressInformation : ChildWindow
       private IFCAddress m_newAddress = new IFCAddress();
       private IFCAddressItem m_newAddressItem = new IFCAddressItem();
       private IFCAddressItem m_savedAddressItem = new IFCAddressItem();
+      private IFCExportConfiguration m_parentConfiguration = null;
 
       private string getUserDefinedStringFromIFCPurposeList()
       {
@@ -59,8 +60,11 @@ private string getUserDefinedStringFromIFCPurposeList()
       public IFCAddressInformation(IFCExportConfiguration configuration)
       {
          InitializeComponent();
+         m_parentConfiguration = configuration;
 
-         m_newAddressItem = configuration.ProjectAddress;
+         if ((configuration.ProjectAddress.HasData() && !m_newAddressItem.HasData()) 
+            || (configuration.ProjectAddress.HasData() && m_newAddressItem.HasData() && !configuration.ProjectAddress.isUnchanged(m_newAddressItem)))
+            m_newAddressItem = configuration.ProjectAddress;
 
          // This is a short list, so we just do an O(n) search.
          int numItems = ifcPurposeList.Count();
@@ -73,11 +77,10 @@ public IFCAddressInformation(IFCExportConfiguration configuration)
             }
          }
 
-         // Initialize options from the m_newAddressItem
-         Checkbox_AssignToBuilding.IsChecked = m_newAddressItem.AssignAddressToBuilding;
-         Checkbox_AssignToSite.IsChecked = m_newAddressItem.AssignAddressToSite;
-         UpdateProjInfocheckBox.IsChecked = m_newAddressItem.UpdateProjectInformation;
-
+         // Initialize options from the configuration
+         Checkbox_AssignToBuilding.IsChecked = configuration.ProjectAddress.AssignAddressToBuilding;
+         Checkbox_AssignToSite.IsChecked = configuration.ProjectAddress.AssignAddressToSite;
+         UpdateProjInfocheckBox.IsChecked = configuration.ProjectAddress.UpdateProjectInformation;
       }
 
       private void OnInit(object sender, RoutedEventArgs e)
@@ -212,7 +215,7 @@ private void buttonOK_Click(object sender, RoutedEventArgs args)
 
             transaction.Commit();
          }
-
+         m_parentConfiguration.ProjectAddress = m_newAddressItem;
          Close();
       }
 

Source/IFCExporterUIOverride/IFCClassificationUI.xaml.cs

@@ -78,7 +78,10 @@ private void buttonOK_Click(object sender, RoutedEventArgs args)
             {
                fillMandatoryFields(m_newClassification);
             }
-            m_newClassification.ClassificationEditionDate = datePicker1.SelectedDate.Value.Date;
+            if (datePicker1?.SelectedDate != null)
+            {
+               m_newClassification.ClassificationEditionDate = datePicker1.SelectedDate.Value.Date;
+            }
             IFCClassificationMgr.UpdateClassification(IFCCommandOverrideApplication.TheDocument, m_newClassification);
          }
 
@@ -134,7 +137,7 @@ private void ClassificationTab_Initialized(object sender, EventArgs e)
       private void datePicker1_SelectedDateChanged(object sender, System.Windows.Controls.SelectionChangedEventArgs e)
       {
          var picker = sender as DatePicker;
-         if (picker != null)
+         if (picker?.SelectedDate != null)
          {
             m_newClassification.ClassificationEditionDate = picker.SelectedDate.Value.Date; // Picker only use the Date
          }

Source/IFCExporterUIOverride/IFCExport.xaml.cs

@@ -448,8 +448,6 @@ private void buttonEditSetup_Click(object sender, RoutedEventArgs args)
             string selectedConfigName = editorWindow.GetSelectedConfigurationName();
 
             UpdateCurrentSelectedSetupCombo(selectedConfigName);
-
-            updateFileName();
          }
 
          // The SelectionChanged event will be activated again after the Modify Config Window is closed