Removing unused cmdlets (#1312)

AutomatedLab · May 17, 2022 · 124c34e · 124c34e
1 parent 9cf3d26
commit 124c34e
Show file tree

Hide file tree

Showing 8 changed files with 3 additions and 232 deletions.
diff --git a/AutomatedLab.Recipe/Snippets/definition.ps1 b/AutomatedLab.Recipe/Snippets/definition.ps1
@@ -38,9 +38,6 @@
         [string]
         $DefaultLocationName,
 
-        [string]
-        $DefaultStorageAccountName,
-
         [string]
         $DefaultResourceGroupName,
 

diff --git a/AutomatedLab/AutomatedLab.psd1 b/AutomatedLab/AutomatedLab.psd1
@@ -104,7 +104,6 @@
         'Get-LabAzureCertificate',
         'Get-LabAzureDefaultLocation',
         'Get-LabAzureDefaultResourceGroup',
-        'Get-LabAzureDefaultStorageAccount',
         'Get-LabAzureLabSourcesContent',
         'Get-LabAzureLabSourcesStorage',
         'Get-LabAzureLocation',
@@ -197,7 +196,6 @@
         'Enable-LabAutoLogon',
         'Disable-LabAutoLogon',
         'Set-LabAzureDefaultLocation',
-        'Set-LabAzureDefaultStorageAccount',
         'Set-LabAzureWebAppContent',
         'Set-LabDefaultOperatingSystem',
         'Set-LabDefaultVirtualizationEngine',

diff --git a/AutomatedLab/AutomatedLabAzure.psm1 b/AutomatedLab/AutomatedLabAzure.psm1
@@ -687,114 +687,6 @@ function Set-LabAzureDefaultLocation
     Write-LogFunctionExit
 }
 
-function Set-LabAzureDefaultStorageAccount
-{
-    param (
-        [Parameter(Mandatory)]
-        [string]$Name
-    )
-
-    Write-ScreenInfo -Type Warning -Message 'Set-LabAzureDefaultStorageAccount is obsolete'
-    return
-
-    Write-LogFunctionEntry
-
-    Update-LabAzureSettings
-
-    if (-not ($script:lab.AzureSettings.StorageAccounts | Where-Object StorageAccountName -eq $Name))
-    {
-        Microsoft.PowerShell.Utility\Write-Error "Invalid storage account. Please specify one of the following storage accounts: $($script:lab.AzureSettings.StorageAccounts.StorageAccountName -join ', ')"
-        return
-    }
-
-    $script:lab.AzureSettings.DefaultStorageAccount = $script:lab.AzureSettings.StorageAccounts | Where-Object StorageAccountName -eq $Name
-
-    Write-LogFunctionExit
-}
-
-function Get-LabAzureDefaultStorageAccount
-{
-    [CmdletBinding()]
-    param ()
-
-    Write-ScreenInfo -Type Warning -Message 'Set-LabAzureDefaultStorageAccount is obsolete'
-    return
-
-    Write-LogFunctionEntry
-
-    Update-LabAzureSettings
-
-    if (-not $Script:lab.AzureSettings.DefaultStorageAccount)
-    {
-        Write-Error 'The default storage account is not defined. Use Set-LabAzureDefaultStorageAccount to define it.'
-        return
-    }
-
-    $Script:lab.AzureSettings.DefaultStorageAccount
-
-    Write-LogFunctionExit
-}
-
-function New-LabAzureDefaultStorageAccount
-{
-    [CmdletBinding()]
-    param (
-        [Parameter(Mandatory)]
-        [string]$LocationName,
-        [Parameter(Mandatory)]
-        [string]$ResourceGroupName
-    )
-
-    Write-ScreenInfo -Type Warning -Message 'Set-LabAzureDefaultStorageAccount is obsolete'
-    return
-
-    Test-LabHostConnected -Throw -Quiet
-
-    Write-LogFunctionEntry
-
-    Update-LabAzureSettings
-
-    $storageAccountName = "automatedlab$((1..8 | ForEach-Object { [char[]](97..122) | Get-Random }) -join '')"
-
-    $param = @{
-        Name              = $storageAccountName
-        ResourceGroupName = $ResourceGroupName
-        Tag               = @{
-            AutomatedLab = $script:lab.Name
-            CreationTime = Get-Date
-        }
-        Sku               = 'Standard_LRS'
-    }
-
-    if ($LocationName)
-    {
-        $location = Get-LabAzureLocation -LocationName $LocationName -ErrorAction Stop
-        $param.Add('Location', $location.DisplayName)
-        Write-ScreenInfo -Message "Creating a new storage account named '$storageAccountName' for location '$($param.Location)'"
-    }
-
-    $result = New-AzStorageAccount @param -ErrorAction Stop
-
-    if ($result.ProvisioningState -ne 'Succeeded')
-    {
-        throw "Could not create storage account $storageAccountName : $($result.ProvisioningState)"
-    }
-
-    Write-ScreenInfo -Message  'Storage account now created'
-
-    $StorageAccount = Get-AzStorageAccount -ResourceGroupName $ResourceGroupName -Name $storageAccountName
-
-    $ALStorageAccount = [AutomatedLab.Azure.AzureRmStorageAccount]::Create($StorageAccount)
-    $ALStorageAccount.StorageAccountKey = ($StorageAccount | Get-AzStorageAccountKey)[0].Value
-    $script:lab.AzureSettings.StorageAccounts.Add($ALStorageAccount)
-
-    Write-PSFMessage "Added $($script:lab.AzureSettings.StorageAccounts.Count) storage accounts"
-
-    Set-LabAzureDefaultStorageAccount -Name $storageAccountName
-
-    Write-LogFunctionExit
-}
-
 function Get-LabAzureDefaultResourceGroup
 {
     [CmdletBinding()]

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -34,6 +34,7 @@
 - DelayBetweenComputers was ignored
 - Fixed lab location. Sometimes the 'Lab.xml' was stored in 'C:\ProgramData\AutomatedLab' directly.
 - Removing unsupported kickstart parameter for old CentOS versions
+- Removing unused DefaultStorageAccount-Cmdlets
 
 ## 5.41.0 (2022-01-31)
 

diff --git a/Help/AutomatedLab/en-us/Add-LabAzureSubscription.md b/Help/AutomatedLab/en-us/Add-LabAzureSubscription.md
@@ -14,8 +14,8 @@ Adds Azure subscription data to lab
 
 ```
 Add-LabAzureSubscription [[-SubscriptionName] <String>] [-SubscriptionId <Guid>]
- [[-DefaultLocationName] <String>] [[-DefaultStorageAccountName] <String>]
- [[-DefaultResourceGroupName] <String>] [-AutoShutdownTime <TimeSpan>] [-AutoShutdownTimeZone <String>]
+ [[-DefaultLocationName] <String>] [[-DefaultResourceGroupName] <String>]
+  [-AutoShutdownTime <TimeSpan>] [-AutoShutdownTimeZone <String>]
  [-PassThru] [-AllowBastionHost] [<CommonParameters>]
 ```
 
@@ -67,21 +67,6 @@ Accept pipeline input: False
 Accept wildcard characters: False
 ```
 
-### -DefaultStorageAccountName
-The default storage account to choose
-
-```yaml
-Type: String
-Parameter Sets: (All)
-Aliases:
-
-Required: False
-Position: 3
-Default value: None
-Accept pipeline input: False
-Accept wildcard characters: False
-```
-
 ### -DefaultResourceGroupName
 The default resource group to choose
 

diff --git a/Help/AutomatedLab/en-us/Get-LabAzureDefaultStorageAccount.md b/Help/AutomatedLab/en-us/Get-LabAzureDefaultStorageAccount.md
diff --git a/Help/AutomatedLab/en-us/Set-LabAzureDefaultStorageAccount.md b/Help/AutomatedLab/en-us/Set-LabAzureDefaultStorageAccount.md
diff --git a/mkdocs.yml b/mkdocs.yml
@@ -177,7 +177,6 @@ nav:
     - Get-LabAzureCertificate: AutomatedLab/en-us/Get-LabAzureCertificate.md
     - Get-LabAzureDefaultLocation: AutomatedLab/en-us/Get-LabAzureDefaultLocation.md
     - Get-LabAzureDefaultResourceGroup: AutomatedLab/en-us/Get-LabAzureDefaultResourceGroup.md
-    - Get-LabAzureDefaultStorageAccount: AutomatedLab/en-us/Get-LabAzureDefaultStorageAccount.md
     - Get-LabAzureLabSourcesContent: AutomatedLab/en-us/Get-LabAzureLabSourcesContent.md
     - Get-LabAzureLabSourcesStorage: AutomatedLab/en-us/Get-LabAzureLabSourcesStorage.md
     - Get-LabAzureLocation: AutomatedLab/en-us/Get-LabAzureLocation.md
@@ -281,7 +280,6 @@ nav:
     - Restore-LabVMSnapshot: AutomatedLab/en-us/Restore-LabVMSnapshot.md
     - Save-LabVM: AutomatedLab/en-us/Save-LabVM.md
     - Set-LabAzureDefaultLocation: AutomatedLab/en-us/Set-LabAzureDefaultLocation.md
-    - Set-LabAzureDefaultStorageAccount: AutomatedLab/en-us/Set-LabAzureDefaultStorageAccount.md
     - Set-LabAzureWebAppContent: AutomatedLab/en-us/Set-LabAzureWebAppContent.md
     - Set-LabDefaultOperatingSystem: AutomatedLab/en-us/Set-LabDefaultOperatingSystem.md
     - Set-LabDefaultVirtualizationEngine: AutomatedLab/en-us/Set-LabDefaultVirtualizationEngine.md