Make Factory hashable (#204)

* Make Factory hashable * Add PR#
AutomatedTester · Jun 6, 2017 · 24815d7 · 24815d7
1 parent 303b2f6
commit 24815d7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -26,6 +26,8 @@ Changes:
 
 - Fix *str* on Python 2 when ``slots=True``.
   `#198 <https://github.com/python-attrs/attrs/issues/198>`_
+- ``attr.Factory`` is now hashable again.
+  `#204 <https://github.com/python-attrs/attrs/issues/204>`_
 
 
 ----

diff --git a/src/attr/_make.py b/src/attr/_make.py
@@ -965,7 +965,7 @@ def default(self, meth):
 _CountingAttr = _add_cmp(_add_repr(_CountingAttr))
 
 
-@attributes(slots=True, init=False)
+@attributes(slots=True, init=False, hash=True)
 class Factory(object):
     """
     Stores a factory callable.

diff --git a/tests/test_make.py b/tests/test_make.py
@@ -572,6 +572,12 @@ def test_factory_takes_self(self):
 
         assert i is i.x
 
+    def test_factory_hashable(self):
+        """
+        Factory is hashable.
+        """
+        assert hash(Factory(None, False)) == hash(Factory(None, False))
+
     def test_convert_before_validate(self):
         """
         Validation happens after conversion.