Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CrashLoggingDataProvider.releaseName #204

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@ interface CrashLoggingDataProvider {
*/
val buildType: String

/**
* Provides [CrashLogging] with the name of this release.
*/
val releaseName: String

/**
* Provides the [CrashLogging] with information about the user's current locale
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ internal class SentryCrashLogging constructor(
options.apply {
dsn = dataProvider.sentryDSN
environment = dataProvider.buildType
release = dataProvider.releaseName
this.tracesSampleRate = tracesSampleRate
this.profilesSampleRate = profilesSampleRate
isDebug = dataProvider.enableCrashLoggingLogs
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class SentryCrashLoggingTest {
SoftAssertions().apply {
assertThat(options.dsn).isEqualTo(dataProvider.sentryDSN)
assertThat(options.environment).isEqualTo(dataProvider.buildType)
assertThat(options.release).isEqualTo(dataProvider.releaseName)
assertThat(options.release).isNull()
}.assertAll()
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import java.util.Locale
class FakeDataProvider(
override val sentryDSN: String = BuildConfig.SENTRY_TEST_PROJECT_DSN,
override val buildType: String = "testBuildType",
override val releaseName: String = "testReleaseName",
override val locale: Locale? = Locale.US,
override val enableCrashLoggingLogs: Boolean = true,
var crashLoggingEnabled: Boolean = true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ class MainActivity : AppCompatActivity() {
object : CrashLoggingDataProvider {
override val sentryDSN = BuildConfig.SENTRY_TEST_PROJECT_DSN
override val buildType = BuildConfig.BUILD_TYPE
override val releaseName = "test"
override val locale = Locale.US
override val enableCrashLoggingLogs = true
override val performanceMonitoringConfig = PerformanceMonitoringConfig.Enabled(sampleRate = 1.0, profilesSampleRate = 1.0)
Expand Down