Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting edit_flow.php #353

Merged
merged 2 commits into from May 7, 2018
Merged

Documenting edit_flow.php #353

merged 2 commits into from May 7, 2018

Conversation

cojennin
Copy link
Contributor

@cojennin cojennin commented Jun 7, 2016

The start of documentation for Edit Flow. This PR documents edit_flow.php Action's and Method's (there are no Filter's in edit_flow.php).

@cojennin
Copy link
Contributor Author

cojennin commented Jun 7, 2016

@philipjohn thoughts on documentation? Figured I'd start going class by class and documenting the action's, filter's and useful method's in that class.

For the moment I thought it'd be easier to get contributors to contribute documentation if it was kept in Github instead of on editflow.org.

edit copy

@philipjohn
Copy link
Contributor

Great thinking, having this stuff in Git will definitely help!

To make this easier in the future, we should follow the inline documentation standards for these. That way we can piggy back on the code that generates the WP Code Reference (or something similar) to automate documentation on EditFlow.org.

How does that sound?

@cojennin
Copy link
Contributor Author

Sounds great!

Is the tool used for generating the WP Code Reference phpDocumenter? Can just go back through this PR and correctly document those functions using the WP doc standards and then have that file auto-generate.

@philipjohn
Copy link
Contributor

Is the tool used for generating the WP Code Reference phpDocumenter?

It looks like partly, yes. WP-Parser is what makes all the magic happen. Essentially, I think (I'm guessing here) it takes the inline documentation (written to the WP standards) and parses that into pretty docs.

My hope is we can just point that at the Edit Flow source, and commit those auto-generated docs somewhere.

@philipjohn
Copy link
Contributor

Oh, more information on the make.wordpress.org page about 'devhub'.

@cojennin
Copy link
Contributor Author

@philipjohn just getting back around to this

The WP CLI command looks like it can generate some JSON that can later be ingested as WordPress posts.

Not 100% up with how VIP works, but would it be possible to import that JSON into http://editflow.org/?

@cojennin cojennin force-pushed the documentation branch 3 times, most recently from 0167afd to 3f4b377 Compare August 29, 2016 15:40
@cojennin
Copy link
Contributor Author

@philipjohn the phodoc.json file that's part of this commit is what was generated when I ran WP-Parser on the Edit Flow codebase from my machine. Seems like it might work, just need some place to stash the documentation that's accessible. Any thoughts on where to put the docs? Hoping we could store them on editflow.org

@cojennin
Copy link
Contributor Author

cojennin commented Sep 9, 2016

@philipjohn let me know if you have any ideas for where to throw these docs! May try and stage a docs.editflow.org WordPress site (though not sure who owns the domain...) and upload them there to see how it would work.

@rinatkhaziev rinatkhaziev added this to the 0.8.3 milestone May 7, 2018
@rinatkhaziev rinatkhaziev merged commit c87f3b7 into master May 7, 2018
@GaryJones GaryJones deleted the documentation branch December 9, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants