Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace “$” with “jQuery”. #499

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@jameslesliemiller
Copy link
Contributor

commented Jan 26, 2019

Was getting a missing function error for the $, and it was creating a conflict with another plugin. As I understand it, when using jQuery in WordPress, best practice is to always use the jQuery function instead of the $. Updated this file (the source of the error) and everything is peachy. It would be great to have this change rolled into the plug-in, so that I don’t have to keep making it after each update.

Also, I hope I’m going about this the correct way. I got followed the instructions from the plugin website (I think). I’ve never use git for collaboration, so if I did this wrong, please feel free to correct me, it won’t hurt my feelings at all.

@jameslesliemiller

This comment has been minimized.

Copy link
Contributor Author

commented Jan 26, 2019

If it matters, in my case (and at least one other user’s case), it specifically was preventing the Co-Authors Plus plugin from writing the author selection UI to the Authors metabox. See this forum post for details: https://wordpress.org/support/topic/cant-select-change-author-in-add-new-post/#post-11133237

@jameslesliemiller

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

It would be great if someone would merge this PR. It’s been sitting here for 4 months, and it fixes an issue that’s breaking functionality in other plugins.

@jameslesliemiller

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

Please, somebody look at this PR and merge it.

@jameslesliemiller

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

Is anybody even maintaining this plugin anymore?

@szepeviktor

This comment has been minimized.

Copy link

commented Sep 11, 2019

@rebeccahum Could you Merge this one please? @mikeyarce

@rebeccahum rebeccahum merged commit c1ced82 into Automattic:master Sep 11, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jameslesliemiller

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

THANK YOU!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.