Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editorial-comments.js - replace faulty $() with jQuery() to match the rest of file #506

Closed
wants to merge 2 commits into from
Closed

editorial-comments.js - replace faulty $() with jQuery() to match the rest of file #506

wants to merge 2 commits into from

Commits on Apr 12, 2019

  1. editorial-comments.js - replace faulty $() with jQuery() to match… 

    … the rest of file

- On one of my sites, I was getting a site-breaking js error for `$ not defined` caused by line 26 of this file, which had a `$()` jQuery command
- For some reason, most of my sites never had this problem, but this one did. Maybe it's a combination of plugins and a common one makes `$()` available by coincidence.
- Either way, the surrounding code makes it obvious that `editorial-comments` relies on `jQuery()` being available, rather than `$()`
- This patch just fixes that one line (which was the most recently added, it's part of the "notified list" feature added in 0.9) to match the rest and use `jQuery()` like a good kid.
    @jerclarke
    jerclarke committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    27be075 View commit details
    Browse the repository at this point in the history

  2. editorial-comments.js - fix more broken $() calls to use jQuery()

    @jerclarke
    jerclarke committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    a426476 View commit details
    Browse the repository at this point in the history