Update npm packages

[htdat]

Close #620
Close #629
Close #640
Close #641

Description

• Updated node-sass to 4.14.1 (similar to PR Bump node-sass from 4.13.0 to 4.13.1 #620)
• Updated various npm packages by running npm update (including update for lodash Bump lodash from 4.17.15 to 4.17.21 #641)
• Bump ua-parser-js from 0.7.21 to 0.7.28 #640 is not necessary as ua-parser-js no longer exists on any dependency after npm update above.
• Tried to patch "Bump elliptic from 6.4.1 to 6.5.4 Bump elliptic from 6.4.1 to 6.5.4 #629"

Steps to Test

Looking at the E2E and JS tests for this PR https://github.com/Automattic/Edit-Flow/runs/2562511361?check_suite_focus=true

[mikeyarce]

Thanks @htdat - Is there another way to test this without relying on GitHub Actions? Just wondering if I could test this locally and what I should expect or be able to see.

[htdat]

@mikeyarce

Is there another way to test this without relying on GitHub Actions? Just wondering if I could test this locally and what I should expect or be able to see.

Yes, you can test this on your local machine but note that it's not exactly the same with GitHub Actions.

Steps to run similar tests on your local machine:

1. First, you will need to install NodeJS on your computer. It should use v14. E.g: in my computer, it looks like this:

~ node -v
v14.15.4

2. Make sure that you have Docker installed. Docker is used to set up test sites with the wp-env package. AFAIK, the Docker version does not matter. But here is what I have on my local machine:

docker -v
Docker version 19.03.13, build 4484c46d9d

3. Follow all npm commands starting from this line:
   

   Edit-Flow/.github/workflows/e2e-and-js-tests.yml

   Line 28 in 2642a91

   - name: Build Edit Flow

For step 3, you can replace npm ci with npm install in your local machine but in general, that does not matter much as you see the info here https://docs.npmjs.com/cli/v7/commands/npm-ci

What you can expect:

• If you see errors when running npm ci or npm install, you can ignore them, as long as you do not see any error for npm run build.
• If you see errors with npm run wp-env start, it's likely an error with Docker.
• You will not see errors for Lint JS and JS tests but you may see errors for E2E tests.

Regarding E2E tests, I've found out that some tests in tests/e2e/specs/calendar-body.test.js are not stable as described here #652

[nielslange]

Other than the different version of the dependencies, I can confirm that only npm run test-e2e shows an error when running locally. All other commands run as expected and this PR looks good to me.

[nielslange]

Is there a specific reason, why you're not using the latest version, in this case 7.14.3, as seen on https://www.npmjs.com/package/@babel/core?

I noticed that for other dependencies there are also more recent versions available:

• @babel/preset-env: 7.14.1 → 7.14.1
• @testing-library/react: 10.4.9 → 11.2.7
• @testing-library/user-event: 10.4.1 → 13.1.9

I haven't tested all dependencies, but it seems that for many of them more recent versions are available.

[htdat]

Is there a specific reason, why you're not using the latest version, in this case 7.14.3, as seen on https://www.npmjs.com/package/@babel/core?

I simply used npm update for all of these packages as mentioned in this commit f8c2ce1

It looks like 7.14.3 has just been released after my PR here. https://www.npmjs.com/package/@babel/core

The same should go for other dependencies.

[htdat]

I've run npm update. All of the packages should be up-to-date now.